Skip to content

feat: bump to express 5 #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: bump to express 5 #5564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d79947d
feat: bump to express 5
bjohansebas Aug 14, 2025
7f7aa4e
test: update snapshots
bjohansebas Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions lib/Server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,16 +1436,16 @@ class Server {
return level;
};

if (typeof item.logLevel === "undefined") {
item.logLevel = getLogLevelForProxy(
if (typeof item.logger === "undefined") {
item.logger = getLogLevelForProxy(
compilerOptions.infrastructureLogging
? compilerOptions.infrastructureLogging.level
: "info",
);
}

if (typeof item.logProvider === "undefined") {
item.logProvider = () => this.logger;
if (typeof item.logger === "undefined") {
item.logger = () => this.logger;
}

return item;
Expand Down Expand Up @@ -2099,7 +2099,7 @@ class Server {
return;
}

res.setHeader("Content-Type", "application/javascript; charset=UTF-8");
res.setHeader("Content-Type", "text/javascript; charset=utf-8");
res.setHeader("Content-Length", stats.size);

if (req.method === "HEAD") {
Expand Down Expand Up @@ -2262,10 +2262,10 @@ class Server {
if (proxyConfig.target) {
const context = proxyConfig.context || proxyConfig.path;

return createProxyMiddleware(
/** @type {string} */ (context),
proxyConfig,
);
return createProxyMiddleware({
...proxyConfig,
pathFilter: /** @type {string} */ (context),
});
}

if (proxyConfig.router) {
Expand Down
Loading