Skip to content

fix: pass MCP tool timeout from metadata#332

Closed
zerone0x wants to merge 1 commit into
zed-industries:mainfrom
zerone0x:fix/issue-308-mcp-tool-timeout
Closed

fix: pass MCP tool timeout from metadata#332
zerone0x wants to merge 1 commit into
zed-industries:mainfrom
zerone0x:fix/issue-308-mcp-tool-timeout

Conversation

@zerone0x

Copy link
Copy Markdown
Contributor

Summary

Fixes #308

Allows ACP client-provided MCP servers to set Codex's tool_timeout_sec via MCP server _meta metadata (tool_timeout_sec or toolTimeoutSec).

Changes

  • Reads tool_timeout_sec metadata from HTTP and stdio MCP server configs
  • Passes the parsed timeout through to Codex McpServerConfig
  • Adds unit coverage for numeric, string, and invalid timeout metadata

Verification

  • cargo fmt --check
  • git diff --check
  • cargo test mcp_tool_timeout_sec --lib (blocked: local environment has no C linker, cc not found)

@benbrandt

Copy link
Copy Markdown
Member

Hi thanks for taking the time to dig in!
Development is moving to agentclientprotocol/codex-acp. The new adapter is built on the new Codex App Server, and we are pooling implementation and maintenance work across teams there. If this is still needed, please open a PR for that one. Thanks!

@benbrandt benbrandt closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can you support customizing the tool_timeout_sec parameter in McpServerConfig?

2 participants