Skip to content

drivers: comparator: Add Comparator support on Renesas RX #93694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2025
Merged

drivers: comparator: Add Comparator support on Renesas RX #93694

merged 4 commits into from
Oct 15, 2025

Conversation

@quytranpzz
Copy link
Contributor

@quytranpzz quytranpzz commented Jul 25, 2025 •
edited
Loading

Add comparator driver support on Renesas RX130 using LVD peripheral.
This driver uses a voltage threshold as the negative input, while the positive input can be selected between Vcc or the CMPA pin.

@github-actions
Copy link

github-actions bot commented Jul 25, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_renesas zephyrproject-rtos/hal_renesas@e6016c2 zephyrproject-rtos/hal_renesas@7cf7ded zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 25, 2025
@duynguyenxa duynguyenxa added the platform: Renesas RX Renesas Electronics Corp, RX label Jul 25, 2025
@quytranpzz quytranpzz force-pushed the renesas_rx_lvd_support branch 6 times, most recently from 6018f8c to c11e903 Compare July 28, 2025 04:46
@quytranpzz quytranpzz marked this pull request as ready for review August 5, 2025 09:51
@zephyrbot zephyrbot added area: Samples Samples platform: Renesas RA Renesas Electronics Corporation, RA area: RX area: Pinctrl labels Aug 5, 2025
thenguyenyf
thenguyenyf reviewed Aug 5, 2025
View reviewed changes
duynguyenxa
duynguyenxa reviewed Aug 7, 2025
View reviewed changes
@quytranpzz quytranpzz force-pushed the renesas_rx_lvd_support branch from c11e903 to d012894 Compare August 15, 2025 10:45
@quytranpzz quytranpzz force-pushed the renesas_rx_lvd_support branch from 6e06055 to 7da2f1b Compare October 13, 2025 09:55
@zephyrbot zephyrbot requested a review from kartben October 13, 2025 09:57
@quytranpzz quytranpzz force-pushed the renesas_rx_lvd_support branch from 7da2f1b to cab20ba Compare October 14, 2025 02:55
@quytranpzz
Copy link
Contributor Author

quytranpzz commented Oct 14, 2025

This hardware maps really well to the comparator subsystem, check out https://docs.zephyrproject.org/latest/hardware/peripherals/comparator.html , and see the comments I added to this PR. The comparator subsystem comes with documentation, a shell, and test suites, so you get a lot "for free" including portability using it instead of introducing a new API :)

There is a component in tree which contains multiple comparator's as well, check out https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/bindings/comparator/renesas%2Cra-acmphs-global.yaml and https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/bindings/comparator/renesas%2Cra-acmphs.yaml Comparators don't have "channels", a comparator is "a comparator" if there are two channels, there are two comparators :)

@bjarki-andreasen , could you please take a look at the change request? I’ve already updated this driver as comparator

thenguyenyf
thenguyenyf previously approved these changes Oct 14, 2025
View reviewed changes
duynguyenxa
duynguyenxa previously approved these changes Oct 14, 2025
View reviewed changes
@thenguyenyf thenguyenyf mentioned this pull request Oct 14, 2025
Merged
@quytranpzz quytranpzz force-pushed the renesas_rx_lvd_support branch from cab20ba to 462f783 Compare October 14, 2025 10:09
@quytranpzz
Copy link
Contributor Author

quytranpzz commented Oct 14, 2025

hello @bjarki-andreasen , @duynguyenxa , @thenguyenyf , sorry but I just rebased this PR to resolve conflicts, please take a look again. thank you

thenguyenyf
thenguyenyf previously approved these changes Oct 14, 2025
View reviewed changes
@quytranpzz
manifest: hal: renesas: Update commit ID for Renesas HAL
e9c120e 
Update the latest commit ID for HAL Renesas

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz
drivers: comparator: Add comparator driver support for RX
264a6af 
Add comparator support for Renesas RX with LVD

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz
dts: renesas: rx: Add dts property nodes for LVD support
b4eb73b 
Add DTS node for LVD support on RX130

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz
samples: boards: renesas: Add LVD sample for Renesas
66d2170 
Add a simple sample using Comparator API to monitor the
voltage on Renesas boards

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz quytranpzz force-pushed the renesas_rx_lvd_support branch from 462f783 to 66d2170 Compare October 15, 2025 02:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jhedberg jhedberg merged commit 7e1fc96 into zephyrproject-rtos:main Oct 15, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thenguyenyf thenguyenyf thenguyenyf approved these changes

@duynguyenxa duynguyenxa duynguyenxa approved these changes

@gmarull gmarull Awaiting requested review from gmarull

@KhiemNguyenT KhiemNguyenT Awaiting requested review from KhiemNguyenT

@nashif nashif Awaiting requested review from nashif

@thaoluonguw thaoluonguw Awaiting requested review from thaoluonguw

@dleach02 dleach02 Awaiting requested review from dleach02

@khoa-nguyen-18 khoa-nguyen-18 Awaiting requested review from khoa-nguyen-18

@manuargue manuargue Awaiting requested review from manuargue

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@ioannis-karachalios ioannis-karachalios Awaiting requested review from ioannis-karachalios

@soburi soburi Awaiting requested review from soburi

@JarmouniA JarmouniA Awaiting requested review from JarmouniA

@kartben kartben Awaiting requested review from kartben

@bjarki-andreasen bjarki-andreasen Awaiting requested review from bjarki-andreasen

Assignees

@duynguyenxa duynguyenxa

Labels

area: Boards/SoCs area: Comparator area: Devicetree Bindings area: Pinctrl area: RX area: Samples Samples manifest manifest-hal_renesas platform: Renesas RA Renesas Electronics Corporation, RA platform: Renesas RX Renesas Electronics Corp, RX platform: Renesas Renesas

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@quytranpzz @kartben @decsny @JarmouniA @bjarki-andreasen @thenguyenyf @duynguyenxa @jhedberg @zephyrbot