soc: xlnx: zynq7000: add I2C Controllers #98503
Conversation
zephyrbot
requested review from
henrikbrixandersen,
ibirnbaum and
michalsimek
|
forgot to enable the CONFIG_I2C_CADENCE_BROKEN_HOLD_BIT first |
There was a problem hiding this comment.
In this file there's a lot of formatting-only changes. Could you please either include them as a separate commit or not include them? This would ensure clarity of the commit history and blame. Thanks
There was a problem hiding this comment.
I would highly prefer that instead of adding static MMU mappings, you switched the driver over to using the DEVICE_MMIO facilities, so that the driver maps itself in the MMU at init-time (also using a virtual address that's not identity mapped).
You can take this PR as a reference on how DEVICE_MMIO integration works:
#78255
The GEMs are going to need a static mapping in the foreseeable future because of having more than one register space definition, but other than that, several devices that used to define static mappings have already been removed in the past in favor of having them map themselves using DEVICE_MMIO.
Add device tree nodes for the Cadence I2C controllers. Signed-off-by: Simon Maurer <[email protected]>
|
This PR depends on #98599 |
|
5 participants
Add device tree nodes for the Cadence I2C controllers and corresponding MMU entries.