boards: infineon: Add support for Infineon CAT2 based boards #98564

manoj-aerlync · 2025-10-30T10:36:40Z

Introduce CY8CPROTO_041TP EVK
Add support for Infineon CAT2 HAL

nordicjm

split into proper commits e.g. for adding soc, for adding board, look at https://docs.zephyrproject.org/latest/contribute/style/kconfig.html and read and apply rules before re-requesting review

sreeramIfx · 2025-11-19T00:48:39Z

soc/infineon/cat2/CMakeLists.txt

+# SPDX-License-Identifier: Apache-2.0
+
+add_subdirectory(${SOC_SERIES})
+zephyr_compile_definitions($<UPPER_CASE:${CONFIG_SOC}>_${CONFIG_SOC_PART_NUMBER})


Is this required? is it not taken care by the infineon_kconfig.h?

This line is removed from the CMakeLists.txt.

sreeramIfx · 2025-11-19T19:57:41Z

soc/infineon/psoc4/CMakeLists.txt

+# Copyright (c) 2025 Infineon Technologies AG,
+# or an affiliate of Infineon Technologies AG.
+#
+# SPDX-License-Identifier: Apache-2.0


Please use psoc4 instead of cat2 for folder names as well as other places (like variable names)

Replaced cat2 with psoc4 as suggested in all places.

sreeramIfx · 2025-11-19T20:08:40Z

west.yml

        - hal
    - name: hal_infineon
-      revision: f3c571f772209b5970bdd1806da641244b5c4c38
+      revision: 2d37de92236ea62b80562e7381ff43d9522dbbad


please use pull/34 till its merged into hal_infineon

got merged so no changes done

sreeramIfx · 2025-11-19T20:11:17Z

modules/hal_infineon/CMakeLists.txt

  OR CONFIG_SOC_FAMILY_INFINEON_CAT1
-  OR CONFIG_SOC_FAMILY_INFINEON_EDGE)
+  OR CONFIG_SOC_FAMILY_INFINEON_EDGE
+  OR CONFIG_SOC_FAMILY_INFINEON_CAT2)


Suggested change

OR CONFIG_SOC_FAMILY_INFINEON_CAT2)

OR CONFIG_SOC_FAMILY_INFINEON_PSOC4)

Please make this change throughout the PR

Changed CAT2 to PSCO4 throughout the PR.

sreeramIfx · 2025-11-19T20:13:09Z

modules/hal_infineon/Kconfig

+config USE_INFINEON_LP_COMP
+	bool
+	help
+	Enable LP-Comp (Low-Power Comparator) HAL module driver for Infineon devices
+
+config USE_INFINEON_MSCLP
+	bool
+	help
+	Enable MSCLP (Multi-Speed Clock Low-Power) HAL module driver for Infineon devices
+
+config USE_INFINEON_TCPWM_QUADDEC
+	bool
+	help
+	Enable Timer (Timer/Counter/PWM Quadrature Decoder) HAL module driver for
+	Infineon devices
+
+config USE_INFINEON_SMARTIO
+	bool
+	help
+	Enable Smart-IO module driver for Infineon devices


I would recommend dropping these since these peripherals are not yet supported

Dropped above mentioned peripherals.

sreeramIfx · 2025-11-19T20:21:48Z

modules/hal_infineon/mtb-pdl-cat2/CMakeLists.txt

+zephyr_library_compile_definitions(CONFIG_SOC_PART_NUMBER)
+zephyr_library_compile_definitions_ifdef(CONFIG_SOC_FAMILY_INFINEON_CAT2 $<UPPER_CASE:${CONFIG_SOC}>)
+
+# Generate PDL specific define (w. *_device) for SOC module
+zephyr_library_compile_definitions_ifdef(CONFIG_SOC_PART_NUMBER ${CONFIG_SOC_PART_NUMBER}_device)


Suggested change

zephyr_library_compile_definitions(CONFIG_SOC_PART_NUMBER)

zephyr_library_compile_definitions_ifdef(CONFIG_SOC_FAMILY_INFINEON_CAT2 $<UPPER_CASE:${CONFIG_SOC}>)

# Generate PDL specific define (w. *_device) for SOC module

zephyr_library_compile_definitions_ifdef(CONFIG_SOC_PART_NUMBER ${CONFIG_SOC_PART_NUMBER}_device)

zephyr_library_compile_definitions(CONFIG_SOC_PART_NUMBER)

zephyr_library_compile_definitions($<UPPER_CASE:${CONFIG_SOC}>)

zephyr_library_compile_definitions(${CONFIG_SOC_PART_NUMBER}_device)

Remove redundant checks

sreeramIfx · 2025-11-19T20:22:29Z

modules/hal_infineon/mtb-pdl-cat2/CMakeLists.txt

+
+# Include directories
+zephyr_include_directories(${pdl_drv_dir}/include)
+zephyr_include_directories_ifdef(CONFIG_SOC_FAMILY_INFINEON_CAT2 ${pdl_dev_dir}/include)


Checking for CONFIG_SOC_FAMILY_INFINEON_CAT2 is redundant since this file is included only if its CONFIG_SOC_FAMILY_INFINEON_CAT2. Please update throughout the file

sreeramIfx · 2025-11-19T22:00:20Z

dts/bindings/arm/infineon,cat2-scb.yaml

+#
+# SPDX-License-Identifier: Apache-2.0
+
+description: Infineon Serial Communication Blocks (SCB) node


Why do we need a separate binding file for UART?

changed using existing one

jsbatch · 2025-11-20T00:26:52Z

boards/infineon/cy8cproto_041tp/docs/index.rst

+.. target-notes::
+
+.. _cy8cproto_041tp Board Website:
+   https://www.infineon.com/assets/row/public/documents/30/57/infineon-psoc-4100t-plus-architecture-trm-additionaltechnicalinformation-en.pdf


This link points to the TRM for the PSOC 4100T Plus MCU, not the board website.

Placed the link for cy8cproto_041tp Board Website

jsbatch · 2025-11-20T00:29:44Z

drivers/clock_control/Kconfig.ifx_cat2

This file looks like a duplicate of options defined in Kconfig.ifx_cat1, so I don't think this file is necessary.

Removed the Kconfig.ifx_cat2 file.

jsbatch · 2025-11-20T00:32:09Z

drivers/clock_control/clock_control_ifx_fixed_clock.c

+#if defined(CONFIG_SOC_FAMILY_INFINEON_CAT2)
+		Cy_SysClk_ImoEnable();
+		int err = Cy_SysClk_ImoSetFrequency(config->rate);
+
+		if (err != CY_SYSCLK_SUCCESS) {
+			printk("Failed to set IMO frequency with (error: %d)\n", err);
+			return -EIO;
+		}
+#endif


Can these use device tree (as done for clk_pilo) instead of soc family for better portability between devices?

Cy_SysClk_ImoSetFrequency is not there in cat1 so checked with dts above this case, as well as used psoc4 for checking imo set freq alone.

jsbatch · 2025-11-20T00:32:22Z

drivers/clock_control/clock_control_ifx_fixed_clock.c

+#if !defined(CONFIG_SOC_FAMILY_INFINEON_CAT2)
 	case IFX_IHO:
 		Cy_SysClk_IhoEnable();
 		break;
+#endif


Can these use device tree (as done for clk_pilo) instead of soc family for better portability between devices?

used dts to check, changed

jsbatch · 2025-11-20T17:13:02Z

include/zephyr/drivers/serial/uart_ifx.h

+#define CONVERT_UART_STOP_BITS_Z_TO_CY(sb)                                                         \
+	(((sb) <= UART_CFG_STOP_BITS_2) ? stop_bits_lut[(sb)] : CY_SCB_UART_STOP_BITS_1)
+
+#define CONVERT_UART_DATA_BITS_Z_TO_CY(db)                                                         \
+	(((db) <= UART_CFG_DATA_BITS_9) ? data_bits_lut[(db)] : 1U)


Rather than fail silently in the case of misconfiguration, it'd be better to log a warning or provide some other feedback.

Updated the code to use LOG_WRN

jsbatch · 2025-11-20T17:36:37Z

boards/infineon/cy8cproto_041tp/docs/index.rst

+.. _cy8cproto_041tp Board Website:
+   https://www.infineon.com/assets/row/public/documents/30/57/infineon-psoc-4100t-plus-architecture-trm-additionaltechnicalinformation-en.pdf
+
+.. _ModusToolbox:


https://www.infineon.com/design-resources/development-tools/sdk/modustoolbox-software

Placed given link for ModusToolbox

jsbatch · 2025-11-20T17:37:04Z

boards/infineon/cy8cproto_041tp/docs/index.rst

+    https://softwaretools.infineon.com/tools/com.ifx.tb.tool.modustoolbox
+
+.. _ModusToolbox Programming Tools:
+    https://softwaretools.infineon.com/tools/com.ifx.tb.tool.modustoolboxprogtools


https://www.infineon.com/design-resources/development-tools/sdk/modustoolbox-software/modustoolbox-programming-tools

Placed above given link for ModusToolbox Programming Tool

jsbatch · 2025-11-20T17:48:10Z

drivers/serial/uart_ifx_cat1_pdl.c

+#if !defined(CONFIG_SOC_SERIES_PSOC4100TP)
 	.rxFifoTriggerLevel = 63UL,
+#else
+	.rxFifoTriggerLevel = 7,
+#endif
 	.rxFifoIntEnableMask = 0UL,
+#if !defined(CONFIG_SOC_SERIES_PSOC4100TP)
 	.txFifoTriggerLevel = 63UL,
+#else
+	.txFifoTriggerLevel = 0,
+#endif


Rather than use hardcoded magic numbers here that differ between parts, I'd rather see #define values. I think it makes the structure definition more readable.

Replaced the hard-coded values with macros.

jsbatch · 2025-11-20T17:54:18Z

dts/arm/infineon/cat2/psoc4100tp/psoc4100tp.44-tqfp.dtsi

Pinmux definitions are missing for 44-pin and 48-pin parts.

Included pinmux definitions for 44-pin variant.

jsbatch · 2025-11-20T17:54:29Z

dts/arm/infineon/cat2/psoc4100tp/psoc4100tp.48-qfn.dtsi

Pinmux definitions are missing for 44-pin and 48-pin parts.

Included pinmux definitions for 48-pin variant.

jsbatch · 2025-11-20T23:44:17Z

include/zephyr/drivers/serial/uart_ifx.h

+#define CONVERT_UART_PARITY_Z_TO_CY(parity) (parity_lut[(parity)])
+
+#define CONVERT_UART_STOP_BITS_Z_TO_CY(sb)                                                         \
+	(((sb) <= UART_CFG_STOP_BITS_2) ? stop_bits_lut[(sb)] : CY_SCB_UART_STOP_BITS_1)
+
+#define CONVERT_UART_DATA_BITS_Z_TO_CY(db)                                                         \
+	(((db) <= UART_CFG_DATA_BITS_9) ? data_bits_lut[(db)] : 1U)
+
+#define IFX_UART_BAUD_DIFF(actual, baud)                                                           \
+	(((actual) > (baud)) ? (((actual) * 100U - (baud) * 100U) / (baud))                        \
+	 : (((baud) * 100U - (actual) * 100U) / (baud)))
+
+#define IFX_UART_DIVIDER(freq, baud, oversample)                                                   \
+	(((freq) + (((baud) * (oversample)) / 2U)) / ((baud) * (oversample)))
+
+#define IFX_UART_MEM_WIDTH(cfg)                                                                    \
+	(((cfg).dataWidth <= CY_SCB_BYTE_WIDTH) ? (CY_SCB_CTRL_MEM_WIDTH_BYTE)                     \
+	 : (CY_SCB_CTRL_MEM_WIDTH_HALFWORD))


If these are being pulled out of the code, I think it would be better to turn them into inline functions instead of macros. I find inline functions to be more readable and more maintainable.

Updated the code to replace the macros with static inline functions as recommended.

Update hal_infineon revision to add PSOC4 family support Signed-off-by: Dharun krithik k <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

Add Kconfig configuration support for PSoC4 family in hal_infineon module. Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

Add CMake build configuration support for PSoC4 PDL and templates. Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

Add base devicetree support for Infineon PSoC4100TP series including: - Core SoC devicetree (psoc4100tp.dtsi) - CM0+ core configuration (psoc4100tp.cm0p.dtsi) - Pin package variants (44-TQFP, 48-QFN, 48-TQFP, 64-TQFP) - System clocks configuration (system_clocks.dtsi) Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

Add devicetree support for CY8C4146 MPN variants including: - AXI packages (T403, T413, T453) - AZI packages (T403-T455) - AZQ packages (T413, T453) - LQI packages (T403, T413, T453) Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

Add devicetree support for CY8C4147 MPN variants including: - AXI packages (T403-T493) - AZI packages (T403-T475) - AZQ packages (T415-T495) - LQI packages (T403-T473) - LQQ package (T493) Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

Add SoC port for the Infineon PSoC4100TP series, including: - Core initialization - Kconfig files - YAML device definitions - SoC-specific pin control configuration Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

Add board porting for the Infineon CY8CPROTO-041TP evaluation kit: - Board devicetree and pinctrl configuration - Kconfig and YAML definitions - Documentation - Support for west build, west flash, and west debug (OpenOCD) Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

Add clock control driver support for Infineon PSoC4: - Fixed clock driver (clock_control_ifx_fixed_clock.c) - Fixed factor clock driver (clock_control_ifx_fixed_factor_clock.c) - Peripheral clock driver (clock_control_ifx_peri_clock.c) - CAT1 clock control header Provides clock initialization and management based on devicetree configuration. Signed-off-by: Dharun krithik k <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

Add initial implementation of the Infineon PSOC4 UART driver based on the Peripheral Driver Library (PDL) for PSOC4 (PSoC 4100TP) devices. Features: - UART transmit and receive using PDL SCB UART APIs - Configurable baud rate, parity, stop bits, and data bits from devicetree - Pinctrl integration for TX/RX pins - Support for Zephyr console and shell subsystems - Build-time validation for UART configuration parameters Signed-off-by: Dharun krithik k <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

sonarqubecloud · 2025-11-25T17:39:57Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
14.7% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added platform: Infineon Infineon Technologies AG area: Boards/SoCs labels Oct 30, 2025

zephyrbot requested review from mcatee-infineon, parthitce, sreeramIfx and talih0 October 30, 2025 10:38

zephyrbot assigned sreeramIfx Oct 30, 2025

nordicjm requested changes Oct 30, 2025

View reviewed changes

manoj-aerlync force-pushed the cy8cproto_041tp_introduction branch 4 times, most recently from 929d3b7 to 2ce5f0a Compare October 30, 2025 12:15

zephyrbot added area: Devicetree Bindings area: Clock Control labels Oct 30, 2025

zephyrbot requested a review from nordic-krch October 30, 2025 12:35

manoj-aerlync force-pushed the cy8cproto_041tp_introduction branch from dfcbfbf to c8effe6 Compare October 30, 2025 12:51

manoj-aerlync marked this pull request as draft October 30, 2025 13:13

dharunkrithikk force-pushed the cy8cproto_041tp_introduction branch from 5bf7770 to 8d4df53 Compare October 30, 2025 13:35

Deepika-aerlync force-pushed the cy8cproto_041tp_introduction branch from 8d4df53 to b42f3ce Compare October 30, 2025 14:41

dharunkrithikk force-pushed the cy8cproto_041tp_introduction branch 4 times, most recently from 56cd6da to 0de383f Compare November 4, 2025 04:55

manoj-aerlync marked this pull request as ready for review November 4, 2025 04:57

zephyrbot added area: Pinctrl area: UART Universal Asynchronous Receiver-Transmitter area: I2C area: SPI SPI bus area: Counter labels Nov 4, 2025

zephyrbot requested a review from dcpleung November 4, 2025 04:59

sreeramIfx requested changes Nov 19, 2025

View reviewed changes

sreeramIfx reviewed Nov 19, 2025

View reviewed changes

sreeramIfx requested changes Nov 19, 2025

View reviewed changes

jsbatch requested changes Nov 20, 2025

View reviewed changes

jsbatch reviewed Nov 20, 2025

View reviewed changes

Deepika-aerlync force-pushed the cy8cproto_041tp_introduction branch from 4cd4833 to a84336e Compare November 24, 2025 12:50

zephyrbot added area: LVGL Light and Versatile Graphics Library Support platform: NXP NXP labels Nov 24, 2025

zephyrbot requested review from axelnxp and billwatersiii November 24, 2025 12:52

Deepika-aerlync force-pushed the cy8cproto_041tp_introduction branch from a84336e to 3fd22d4 Compare November 25, 2025 05:50

zephyrbot requested review from avisconti, decsny, dleach02, faxe1008, mmahadevan108 and sreeramIfx November 25, 2025 05:52

Deepika-aerlync added 3 commits November 25, 2025 15:28

manifest: hal_infineon: update rev to latest

cf56538

Update hal_infineon revision to add PSOC4 family support Signed-off-by: Dharun krithik k <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

modules: hal_infineon: add PSoC4 Kconfig support

0a8b4e7

Add Kconfig configuration support for PSoC4 family in hal_infineon module. Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

modules: hal_infineon: add PSoC4 build support

a5957c9

Add CMake build configuration support for PSoC4 PDL and templates. Signed-off-by: Manojkumar Konisetty <[email protected]> Signed-off-by: Sayooj K Karun <[email protected]> Signed-off-by: Deepika aerlync <[email protected]>

manoj-aerlync force-pushed the cy8cproto_041tp_introduction branch from 3fd22d4 to e560bfd Compare November 25, 2025 10:20

Deepika-aerlync added 7 commits November 25, 2025 22:17

Deepika-aerlync force-pushed the cy8cproto_041tp_introduction branch from e560bfd to 124a2f5 Compare November 25, 2025 17:02

	OR CONFIG_SOC_FAMILY_INFINEON_CAT2)
	OR CONFIG_SOC_FAMILY_INFINEON_PSOC4)

boards: infineon: Add support for Infineon CAT2 based boards #98564

Are you sure you want to change the base?

boards: infineon: Add support for Infineon CAT2 based boards #98564

Conversation

manoj-aerlync commented Oct 30, 2025

Uh oh!

nordicjm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment