Multiblock Refactor by YoungOnionMC · Pull Request #3119 · GregTechCEu/GregTech-Modern

YoungOnionMC · 2025-04-30T07:56:47Z

What

Multiblock refactor, TBD

TODO

…rsed, there are RACE CONDITIONS

… into yo/the-patterning # Conflicts: # src/main/java/com/gregtechceu/gtceu/api/block/MetaMachineBlock.java # src/main/java/com/gregtechceu/gtceu/api/machine/MultiblockMachineDefinition.java # src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/MultiblockControllerMachine.java # src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/WorkableMultiblockMachine.java # src/main/java/com/gregtechceu/gtceu/api/multiblock/Predicates.java # src/main/java/com/gregtechceu/gtceu/api/multiblock/predicates/SimplePredicate.java # src/main/java/com/gregtechceu/gtceu/api/pattern/BlockPattern.java # src/main/java/com/gregtechceu/gtceu/api/pattern/FactoryBlockPattern.java # src/main/java/com/gregtechceu/gtceu/api/pattern/MultiblockState.java # src/main/java/com/gregtechceu/gtceu/api/pattern/util/RelativeDirection.java # src/main/java/com/gregtechceu/gtceu/client/model/WorkableOverlayModel.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GTMultiMachines.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/ActiveTransformerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/AssemblyLineMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/CleanroomMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/FusionReactorMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/LargeMinerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/PowerSubstationMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/DataBankMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/HPCAMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/ResearchStationMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/steam/SteamParallelMultiblockMachine.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/GregTechKubeJSPlugin.java

…lets::lets::lets::lets::lets:

…atterns

…to use the correct orientation

…in aisle iteration

…ng, fix ghost controllers existing when controller invalidate and break, give research station obj holder error message

…e a custom recipe logic rather than subscribing a tick method

…ocks exclusively

jurrejelle · 2025-06-16T08:18:18Z

fixes #3232

…sePredicate, BasePredicate candidates now use CompoundTag instead of String, String mapping. Start work on the autobuilder system.

Ghostipedia · 2025-07-18T11:13:52Z

Added Admin-Merge Req to this PR, we need to review what currently is done and then start to migrate to doing smaller PR's into this branch

…ch-Modern into yo/the-patterning # Conflicts: # src/main/java/com/gregtechceu/gtceu/api/block/IMachineBlock.java # src/main/java/com/gregtechceu/gtceu/api/block/MetaMachineBlock.java # src/main/java/com/gregtechceu/gtceu/api/blockentity/MetaMachineBlockEntity.java # src/main/java/com/gregtechceu/gtceu/api/gui/widget/PatternPreviewWidget.java # src/main/java/com/gregtechceu/gtceu/api/machine/MetaMachine.java # src/main/java/com/gregtechceu/gtceu/api/machine/MultiblockMachineDefinition.java # src/main/java/com/gregtechceu/gtceu/api/machine/feature/multiblock/IMultiController.java # src/main/java/com/gregtechceu/gtceu/api/machine/feature/multiblock/IRotorHolderMachine.java # src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/CoilWorkableElectricMultiblockMachine.java # src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/MultiblockControllerMachine.java # src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/MultiblockDisplayText.java # src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/WorkableMultiblockMachine.java # src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/part/MultiblockPartMachine.java # src/main/java/com/gregtechceu/gtceu/api/multiblock/MultiblockWorldSavedData.java # src/main/java/com/gregtechceu/gtceu/api/pattern/BlockPattern.java # src/main/java/com/gregtechceu/gtceu/api/pattern/MultiblockState.java # src/main/java/com/gregtechceu/gtceu/api/pattern/Predicates.java # src/main/java/com/gregtechceu/gtceu/api/pattern/util/RelativeDirection.java # src/main/java/com/gregtechceu/gtceu/api/registry/registrate/MultiblockMachineBuilder.java # src/main/java/com/gregtechceu/gtceu/client/renderer/cover/FacadeCoverRenderer.java # src/main/java/com/gregtechceu/gtceu/client/renderer/machine/FusionReactorRenderer.java # src/main/java/com/gregtechceu/gtceu/client/renderer/machine/HPCAPartRenderer.java # src/main/java/com/gregtechceu/gtceu/client/renderer/machine/LargeBoilerRenderer.java # src/main/java/com/gregtechceu/gtceu/client/renderer/machine/MachineRenderer.java # src/main/java/com/gregtechceu/gtceu/client/renderer/machine/PrimitiveBlastFurnaceRenderer.java # src/main/java/com/gregtechceu/gtceu/client/renderer/machine/gcym/LargeChemicalBathRenderer.java # src/main/java/com/gregtechceu/gtceu/client/renderer/machine/gcym/LargeMixerRenderer.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GCYMMachines.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GTMachineUtils.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GTMultiMachines.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GTResearchMachines.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/ActiveTransformerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/AssemblyLineMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/CleanroomMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/DistillationTowerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/FluidDrillMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/FusionReactorMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/LargeMinerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/PowerSubstationMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/gcym/LargeChemicalBathMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/gcym/LargeMixerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/DataBankMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/HPCAMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/generator/LargeCombustionEngineMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/FluidHatchPartMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/OpticalComputationHatchMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/ParallelHatchPartMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/primitive/CharcoalPileIgniterMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/primitive/PrimitiveBlastFurnaceMachine.java # src/main/java/com/gregtechceu/gtceu/core/mixins/ChunkMixin.java # src/main/java/com/gregtechceu/gtceu/core/mixins/LevelMixin.java # src/main/java/com/gregtechceu/gtceu/forge/ForgeCommonEventListener.java # src/main/java/com/gregtechceu/gtceu/integration/jade/provider/MultiblockStructureProvider.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/GregTechKubeJSPlugin.java # src/main/java/com/gregtechceu/gtceu/integration/top/provider/MultiblockStructureProvider.java # src/main/java/com/gregtechceu/gtceu/utils/GTMatrixUtils.java # src/main/java/com/gregtechceu/gtceu/utils/GTStringUtils.java # src/main/java/com/gregtechceu/gtceu/utils/GTUtil.java

…the game to run again, need to fix model rotations again

YoungOnionMC added 30 commits February 22, 2025 11:55

start of patterns

12aaab1

erm mots?

48a4496

buddy

a3572e7

predicate nonsense

ffa9b0e

structure forming logic

ab7fc1b

activeblock storing

f92b9e0

method renaming

e4ed154

imports

edf515b

start of structure forming in game

c11c5a6

forgor a file

25fe550

edit upwards facing

32d0fb4

erm

1bcf1e5

multiblock code :)

ee07930

the multiblock state partial works, parts are dumb

cf7bbff

structure forming and unforming works :lets: wall sharing is kinda cu…

d08f9c2

…rsed, there are RACE CONDITIONS

predicate printing :)

c0cb953

package renaming

d6f7e67

merge dn

c90fcaf

global to relative stuff

bdfdd1d

removal of BetterBlockPos, use MutableBlockPos instead :)

c435a0f

101 dalmatians

b02ef7d

SinglePredicateError Type enumeration and CBI npe

85fb7f6

thread locking stuff(doesnt work), use embedded level tinter

684c343

stuff still doesnt work

cee618d

stuff works again, fixed recipe logic as well

2fee63d

Substructures work BAYBEE :lets::lets::lets::lets::lets::lets::lets::…

60df005

…lets::lets::lets::lets::lets:

Expandable patterns(cleanroom) works, current bug when reloading world

5158d0a

Helper Funcs for OriginOffset, fixing certain world load orders for p…

f8c6a67

…atterns

fix recipe logic resetting on world load

485ae01

YoungOnionMC added 11 commits June 14, 2025 16:17

multi edge cases and anchor position setting

e0adecb

predicate equality, multi line predicate error info, fix MOST multis …

500126d

…to use the correct orientation

move multi aisle int array to an actual data class, fix slight error …

99c9df2

…in aisle iteration

fix aisle repetition for extruder

5fa0748

fix autobuilding machines to correctly orient post placement

dacb3a3

expandable pattern autobuilder, get data bank, research station worki…

e1bb831

…ng, fix ghost controllers existing when controller invalidate and break, give research station obj holder error message

completely fix and rewrite the charcoal pile ignitor update logic, us…

65bf8eb

…e a custom recipe logic rather than subscribing a tick method

edit miners and drills to use the frame predicate instead of frame bl…

cdc7723

…ocks exclusively

various error reporting whenever a multiblock tries to invalidate

2ae0728

more CPI fixing

d70f4e5

spotless dn

2718bf1

screret linked an issue Jun 16, 2025 that may be closed by this pull request

Fluid miner multiblock doesn't allow framed cables/pipes #3232

Open

2 tasks

YoungOnionMC added 2 commits June 16, 2025 22:39

fix the "randomness" of predicates for candidate matching

abec38b

Refactor TraceabilityPredicate->PatternPredicate, SimplePredicate->Ba…

745ed40

…sePredicate, BasePredicate candidates now use CompoundTag instead of String, String mapping. Start work on the autobuilder system.

Ghostipedia added Do Not Merge DO NOT MERGE THIS PR YET! type: refactor Suggestion to refactor a section of code Feature Frozen Content Slated for NEXT update during a testing-cycle. Effectively, do not merge with this update. labels Jul 1, 2025

YoungOnionMC removed the Feature Frozen Content Slated for NEXT update during a testing-cycle. Effectively, do not merge with this update. label Jul 17, 2025

Ghostipedia added Release: API - X.0.0 Major Breaking Refactors that MUST be in a API-Breaking Release Admin Merge Requires Specialized Merge Permissions -Ask Org Admin to merge labels Jul 18, 2025

YoungOnionMC changed the base branch from 1.20.1 to 1.20.1-v8.0.0 January 12, 2026 03:36

YoungOnionMC added 2 commits January 19, 2026 12:25

merge 8.0.0 into the patterning, clean up relative direction and get …

a0517eb

…the game to run again, need to fix model rotations again

github-actions bot added 1.20.1 Tests: Failed Game Tests have failed on this PR labels Jan 20, 2026

fix up model rotations

51e5232

Base automatically changed from 1.20.1-v8.0.0 to 1.20.1 February 14, 2026 22:08

YoungOnionMC mentioned this pull request Mar 2, 2026

Remove more ldlib stuff #4705

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiblock Refactor#3119

Multiblock Refactor#3119
YoungOnionMC wants to merge 53 commits into1.20.1from
yo/the-patterning

YoungOnionMC commented Apr 30, 2025 •

edited

Loading

Uh oh!

jurrejelle commented Jun 16, 2025

Uh oh!

Ghostipedia commented Jul 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

YoungOnionMC commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

TODO

Uh oh!

jurrejelle commented Jun 16, 2025

Uh oh!

Ghostipedia commented Jul 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YoungOnionMC commented Apr 30, 2025 •

edited

Loading