Walking engine tidying #1810
Open
Walking engine tidying #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schluis
added
the
is:Refactoring
oleflb
requested changes
Mar 26, 2025
Comment on lines
+13
to
+28
| left_sole_to_robot: linear_algebra::Transform<LeftSole, Robot, Isometry3<f32>>, | ||
| right_sole_to_robot: linear_algebra::Transform<RightSole, Robot, Isometry3<f32>>, | ||
| ) -> LowerBodyJoints<f32> { | ||
| let left_foot: Pose3<LeftSole> = | ||
| linear_algebra::Isometry3::from(RobotDimensions::LEFT_ANKLE_TO_LEFT_SOLE) | ||
| .inverse() | ||
| .as_pose(); | ||
|
|
||
| let right_foot: Pose3<RightSole> = | ||
| linear_algebra::Isometry3::from(RobotDimensions::RIGHT_ANKLE_TO_RIGHT_SOLE) | ||
| .inverse() | ||
| .as_pose(); | ||
|
|
||
| let left_foot = left_sole_to_robot * left_foot; | ||
| let right_foot = right_sole_to_robot * right_foot; | ||
|
|
There was a problem hiding this comment.
I don't understand why this is nicer than before, can you elaborate on that?
| ) | ||
| }; | ||
| let (backward_acceleration, forward_acceleration) = | ||
| if last_requested_step.forward > f32::EPSILON { |
There was a problem hiding this comment.
What is the motivation for this change?
|
I discussed these changes with @schluis a few days ago. This PR is still in progress and should not be merged in the current state. Moving back to in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
How to Test