Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: compute min between 2 envelope parts and use it in ETCS #10991

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

core: compute min between 2 envelope parts and use it in ETCS #10991

wants to merge 10 commits into from
+1,439 −1,231

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented Mar 3, 2025 •
edited
Loading

Compute the min curve between 2 envelope parts and use it in ETCS to compute min between indicationSvL and indicationEoA more precisely.
Disclaimer: with the simplification of the curves post calculation, there isn't actually a very distinctive improvement in the curve's precision..
image

@github-actions github-actions bot added the area:core Work on Core Service label Mar 3, 2025
@Erashin Erashin mentioned this pull request Mar 3, 2025
Merged
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (1b37d58) to head (e97486f).
Report is 38 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10991      +/-   ##
==========================================
- Coverage   80.83%   80.80%   -0.04%     
==========================================
  Files        1115     1101      -14     
  Lines      112495   111724     -771     
  Branches      759      759              
==========================================
- Hits        90934    90275     -659     
+ Misses      21506    21394     -112     
  Partials       55       55
Flag Coverage Δ
editoast 72.61% <ø> (+0.14%) ⬆️
front 89.90% <ø> (+0.01%) ⬆️
gateway 2.49% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Erashin Erashin self-assigned this Mar 3, 2025
@Erashin Erashin force-pushed the alch/core/compute-min-envelope-part branch 4 times, most recently from c33c046 to 8b9eaba Compare March 4, 2025 09:05
@Erashin Erashin marked this pull request as ready for review March 4, 2025 09:05
@Erashin Erashin requested a review from a team as a code owner March 4, 2025 09:05
@Erashin Erashin requested review from bougue-pe and eckter March 4, 2025 09:05
@Erashin Erashin changed the title core: compute min between 2 envelope parts core: compute min between 2 envelope parts and use it in ETCS Mar 4, 2025
@Erashin Erashin force-pushed the alch/core/compute-min-envelope-part branch from 8b9eaba to b57fb61 Compare March 4, 2025 09:17
@Erashin Erashin requested a review from a team as a code owner March 4, 2025 09:17
@github-actions github-actions bot added the area:integration-tests Work on Integration test, by nature related to different services label Mar 4, 2025
@Erashin Erashin changed the base branch from dev to alch/core/add_svl_etcs_logic March 4, 2025 09:17
@Erashin Erashin force-pushed the alch/core/add_svl_etcs_logic branch from fb7fde5 to 574a3e7 Compare March 4, 2025 09:20
@Erashin Erashin force-pushed the alch/core/compute-min-envelope-part branch from b57fb61 to 69253bf Compare March 4, 2025 09:21
@github-actions github-actions bot removed the area:integration-tests Work on Integration test, by nature related to different services label Mar 4, 2025
eckter
eckter reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@Erashin Erashin force-pushed the alch/core/add_svl_etcs_logic branch from 574a3e7 to 408d683 Compare March 10, 2025 13:18
@Erashin Erashin mentioned this pull request Mar 10, 2025
Open
15 tasks
Base automatically changed from alch/core/add_svl_etcs_logic to dev March 10, 2025 13:46
@Erashin Erashin force-pushed the alch/core/compute-min-envelope-part branch 3 times, most recently from f612789 to 858975d Compare March 12, 2025 10:34
@Erashin Erashin force-pushed the alch/core/compute-min-envelope-part branch 3 times, most recently from d831936 to a00cb68 Compare March 12, 2025 14:34
@Erashin Erashin force-pushed the alch/core/compute-min-envelope-part branch 2 times, most recently from 2e4f7f3 to be56b70 Compare March 13, 2025 09:02
@Erashin Erashin force-pushed the alch/core/compute-min-envelope-part branch from be56b70 to 7b39438 Compare March 13, 2025 09:57
@github-actions github-actions bot added the area:integration-tests Work on Integration test, by nature related to different services label Mar 13, 2025
@Erashin Erashin requested review from bougue-pe and eckter March 13, 2025 10:48
@eckter eckter mentioned this pull request Mar 13, 2025
Open
eckter
eckter reviewed Mar 14, 2025
View reviewed changes
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but mostly LGTM

@Erashin Erashin force-pushed the alch/core/compute-min-envelope-part branch from 2de208b to 52038bd Compare March 14, 2025 09:21
@Erashin Erashin requested a review from eckter March 14, 2025 09:21
@Erashin Erashin force-pushed the alch/core/compute-min-envelope-part branch from 52038bd to eb8ebd8 Compare March 14, 2025 09:54
@Erashin Erashin force-pushed the alch/core/compute-min-envelope-part branch from eb8ebd8 to 9ef34ab Compare March 14, 2025 10:18
bougue-pe
bougue-pe reviewed Mar 17, 2025
View reviewed changes
bougue-pe
bougue-pe approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments to big PR and more kotlin 🎉
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eckter eckter eckter approved these changes

@bougue-pe bougue-pe bougue-pe approved these changes

Assignees

@Erashin Erashin

Labels
area:core Work on Core Service area:integration-tests Work on Integration test, by nature related to different services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Erashin @codecov-commenter @eckter @bougue-pe