Skip to content

Update the winch state once per time step #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ufechner7 merged 5 commits into from
Oct 10, 2026
Merged

Update the winch state once per time step #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8970e2
Update the winch state once per time step
ufechner7 Oct 10, 2026
0edf4b7
Drop Julia 1.11, use WinchModels 0.3.12 in the default manifests
ufechner7 Oct 10, 2026
5e4bf9c
Move the winch helpers above the docstring of init!
ufechner7 Oct 10, 2026
54f566c
Reset the KPS3 sync speed and the winch brake state in init!
ufechner7 Oct 10, 2026
908f32e
Test that residual! keeps the winch state and next_step! advances it …
ufechner7 Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/Test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
fail-fast: false
matrix:
version:
- '1.11'
- '1.12'
- '1'
os:
- ubuntu-latest
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
fail-fast: false
matrix:
julia_version:
- "1.11"
- "1.12"
julia_arch:
- x64
os:
Expand Down
17 changes: 17 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,23 @@
SPDX-FileCopyrightText: 2025 Uwe Fechner, Bart van de Lint
SPDX-License-Identifier: MIT
-->
### KiteModels v0.11.19 - unreleased
#### Fixed
- The state of the winch (brake on/off, rate limited set speed) is now updated once per time step
in `next_step!` (and reset in `init!` to the initial set speed `set.v_reel_out` and the brake state
after construction, so that repeated calls of `init!` give the same result) instead of on every call of the residual function. Before,
it depended on the number of residual evaluations of the DAE solver, so tiny numerical
differences (e.g. between Julia versions) could switch the brake at a different moment. With a
winch `v_min` of 0.15 m/s this made the reel-out speed of the hydra20 simulations of
KiteControllers.jl run away on Julia 1.13. The simulation results change slightly.
#### Changed
- requires WinchModels 0.3.12 (for `update_winch_state!` and `calc_acceleration(...; update_state)`)
- support Julia 1.12 and 1.13 only, as WinchModels 0.3.12 and KiteUtils do: `julia` compat
`"1.12, 1.13"`, `Manifest-v1.11.toml.default` is removed, `bin/install`,
`bin/update_default_manifest` and `bin/create_sys_image` no longer offer Julia 1.11, CI tests
Julia 1.12 instead of 1.11, and the docs no longer mention Julia 1.11
- the default manifests for Julia 1.12 and 1.13 use WinchModels 0.3.12

### KiteModels v0.11.18 2026-10-10
#### Changed
- The system of equations of `find_steady_state!` (KPS4) is now square and well-posed. Before, one
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Before creating a new release, please check
- test_installation5 work
- execute `meld README.md docs/src/index.md` and make sure both are up-to-date
- test the installation on Linux for all Julia versions listed in the `julia` compat entry of
`Project.toml` (currently 1.11 and 1.12)
`Project.toml` (currently 1.12 and 1.13)
- test the installation on Windows after deleting the .julia folder
- run `pipx run reuse lint` and make sure all files have a license attached;
See: <https://reuse.readthedocs.io/en/latest/readme.html>
Loading
Loading