Skip to content

Conversation

@marmarek
Copy link
Member

@marmarek marmarek commented Apr 8, 2025

Especially, add new devices-related exceptions.

This is needed for salt to properly handle assigning devices.

Especially, add new devices-related exceptions.

This is needed for salt to properly handle assigning devices.
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.65%. Comparing base (3f22073) to head (88fbf74).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   75.64%   75.65%           
=======================================
  Files          52       52           
  Lines        9014     9020    +6     
=======================================
+ Hits         6819     6824    +5     
- Misses       2195     2196    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented Apr 9, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025041016-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update

  • system_tests_devices

    • TC_00_List_whonix-workstation-17: test_001_list_loop_mounted (failure)
      AssertionError: Device test-inst-vm:loop0::0 (/tmp/test.img) should...
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_20_NonAudio_debian-12-xfce-pool: test_210_time_sync (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
  • system_tests_qwt_win10_seamless@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/0ZKG~-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_qwt_win11@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_suspend@hw1

    • suspend: wait_serial (wait serial expected)
      # wait_serial expected: qr/p5~T5-\d+-/...

    • suspend: Failed (test died + timed out)
      # Test died: command 'true' timed out at /usr/lib/os-autoinst/autot...

Failed tests

15 failures
  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_devices

    • TC_00_List_whonix-workstation-17: test_001_list_loop_mounted (failure)
      AssertionError: Device test-inst-vm:loop0::0 (/tmp/test.img) should...
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_20_NonAudio_debian-12-xfce-pool: test_210_time_sync (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_qwt_win10_seamless@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/0ZKG~-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_qwt_win11@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_suspend@hw1

    • suspend: wait_serial (wait serial expected)
      # wait_serial expected: qr/p5~T5-\d+-/...

    • suspend: Failed (test died + timed out)
      # Test died: command 'true' timed out at /usr/lib/os-autoinst/autot...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/132953#dependencies

8 fixed
  • system_tests_basic_vm_qrexec_gui

  • system_tests_qrexec

  • system_tests_kde_gui_interactive

    • clipboard_and_web: unnamed test (unknown)

    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qubes-website' matche...

    • clipboard_and_web: wait_serial (wait serial expected)
      # wait_serial expected: "lspci; echo 2E8vz-\$?-"...

  • system_tests_audio

  • system_tests_guivm_vnc_gui_interactive

    • gui_filecopy: unnamed test (unknown)
    • gui_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'files-work' matched...

Unstable tests

Details

Performance Tests

Performance degradation:

26 performance degradations
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 273208.00 :small_red_triangle_up: ( previous job: 446963.00, degradation: 61.13%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 73058.00 :small_red_triangle_up: ( previous job: 129298.00, degradation: 56.50%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 185135.00 :small_red_triangle_up: ( previous job: 294295.00, degradation: 62.91%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 42129.00 :small_red_triangle_up: ( previous job: 79803.00, degradation: 52.79%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 4285.00 :small_red_triangle_up: ( previous job: 6149.00, degradation: 69.69%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1426.00 :small_red_triangle_up: ( previous job: 4826.00, degradation: 29.55%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 163415.00 :small_red_triangle_up: ( previous job: 382273.00, degradation: 42.75%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 89263.00 :small_red_triangle_up: ( previous job: 250795.00, degradation: 35.59%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 344812.00 :small_red_triangle_up: ( previous job: 437636.00, degradation: 78.79%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 129030.00 :small_red_triangle_up: ( previous job: 184752.00, degradation: 69.84%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 18617.00 :small_red_triangle_up: ( previous job: 62195.00, degradation: 29.93%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 5.00 :small_red_triangle_up: ( previous job: 4903.00, degradation: 0.10%)
  • fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 323434.00 :small_red_triangle_up: ( previous job: 368309.00, degradation: 87.82%)
  • fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 100943.00 :small_red_triangle_up: ( previous job: 162081.00, degradation: 62.28%)
  • fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 263395.00 :small_red_triangle_up: ( previous job: 318716.00, degradation: 82.64%)
  • fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 71508.00 :small_red_triangle_up: ( previous job: 87940.00, degradation: 81.31%)
  • fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2396.00 :small_red_triangle_up: ( previous job: 3599.00, degradation: 66.57%)
  • fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 115905.00 :small_red_triangle_up: ( previous job: 170062.00, degradation: 68.15%)
  • fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 27954.00 :small_red_triangle_up: ( previous job: 61534.00, degradation: 45.43%)
  • fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 1784.00 :small_red_triangle_up: ( previous job: 2215.00, degradation: 80.54%)
  • fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 325442.00 :small_red_triangle_up: ( previous job: 369868.00, degradation: 87.99%)
  • fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 130018.00 :small_red_triangle_up: ( previous job: 179949.00, degradation: 72.25%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 3114.00 :small_red_triangle_up: ( previous job: 5672.00, degradation: 54.90%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 6906.00 :small_red_triangle_up: ( previous job: 7867.00, degradation: 87.78%)
  • whonix-gateway-17_socket: 8.37 :small_red_triangle_up: ( previous job: 7.24, degradation: 115.74%)
  • whonix-gateway-17_socket-root: 8.62 :small_red_triangle_up: ( previous job: 7.65, degradation: 112.69%)

Remaining performance tests:

46 tests
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 138753.00 :green_circle: ( previous job: 95454.00, improvement: 145.36%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 10050.00 :small_red_triangle_up: ( previous job: 10795.00, degradation: 93.10%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 6233.00 :small_red_triangle_up: ( previous job: 6479.00, degradation: 96.20%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 11923.00 :green_circle: ( previous job: 7669.00, improvement: 155.47%)
  • fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 82769.00 :green_circle: ( previous job: 82694.00, improvement: 100.09%)
  • fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8311.00 :small_red_triangle_up: ( previous job: 8485.00, degradation: 97.95%)
  • fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1096.00 :green_circle: ( previous job: 542.00, improvement: 202.21%)
  • fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 365484.00 :small_red_triangle_up: ( previous job: 373957.00, degradation: 97.73%)
  • fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 344926.00 :green_circle: ( previous job: 334687.00, improvement: 103.06%)
  • fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 100028.00 :green_circle: ( previous job: 80283.00, improvement: 124.59%)
  • fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8720.00 :green_circle: ( previous job: 7540.00, improvement: 115.65%)
  • fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1140.00 :green_circle: ( previous job: 1130.00, improvement: 100.88%)
  • fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 320273.00 :small_red_triangle_up: ( previous job: 324737.00, degradation: 98.63%)
  • fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 33520.00 :green_circle: ( previous job: 17567.00, improvement: 190.81%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 74516.00 :small_red_triangle_up: ( previous job: 79021.00, degradation: 94.30%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 2638.00 :green_circle: ( previous job: 1953.00, improvement: 135.07%)
  • debian-12-xfce_exec: 6.79 🟢 ( previous job: 7.12, improvement: 95.32%)
  • debian-12-xfce_exec-root: 31.46 :small_red_triangle_up: ( previous job: 28.65, degradation: 109.78%)
  • debian-12-xfce_socket: 8.77 :small_red_triangle_up: ( previous job: 8.60, degradation: 101.95%)
  • debian-12-xfce_socket-root: 8.31 🟢 ( previous job: 8.52, improvement: 97.51%)
  • debian-12-xfce_exec-data-simplex: 65.75 🟢 ( previous job: 71.62, improvement: 91.81%)
  • debian-12-xfce_exec-data-duplex: 70.08 🟢 ( previous job: 70.34, improvement: 99.63%)
  • debian-12-xfce_exec-data-duplex-root: 85.42 :small_red_triangle_up: ( previous job: 82.72, degradation: 103.27%)
  • debian-12-xfce_socket-data-duplex: 157.64 :small_red_triangle_up: ( previous job: 156.96, degradation: 100.43%)
  • fedora-41-xfce_exec: 9.30 :small_red_triangle_up: ( previous job: 9.27, degradation: 100.39%)
  • fedora-41-xfce_exec-root: 62.58 :small_red_triangle_up: ( previous job: 61.51, degradation: 101.74%)
  • fedora-41-xfce_socket: 8.61 🟢 ( previous job: 8.63, improvement: 99.73%)
  • fedora-41-xfce_socket-root: 8.23 🟢 ( previous job: 8.71, improvement: 94.54%)
  • fedora-41-xfce_exec-data-simplex: 59.83 🟢 ( previous job: 75.53, improvement: 79.20%)
  • fedora-41-xfce_exec-data-duplex: 72.46 :small_red_triangle_up: ( previous job: 71.56, degradation: 101.26%)
  • fedora-41-xfce_exec-data-duplex-root: 98.65 🟢 ( previous job: 109.13, improvement: 90.40%)
  • fedora-41-xfce_socket-data-duplex: 133.78 🟢 ( previous job: 150.61, improvement: 88.82%)
  • whonix-gateway-17_exec: 7.08 :small_red_triangle_up: ( previous job: 6.82, degradation: 103.79%)
  • whonix-gateway-17_exec-root: 39.01 🟢 ( previous job: 40.43, improvement: 96.48%)
  • whonix-gateway-17_exec-data-simplex: 79.45 :small_red_triangle_up: ( previous job: 78.32, degradation: 101.44%)
  • whonix-gateway-17_exec-data-duplex: 74.35 🟢 ( previous job: 76.65, improvement: 97.00%)
  • whonix-gateway-17_exec-data-duplex-root: 85.89 🟢 ( previous job: 88.52, improvement: 97.03%)
  • whonix-gateway-17_socket-data-duplex: 172.09 :small_red_triangle_up: ( previous job: 171.76, degradation: 100.19%)
  • whonix-workstation-17_exec: 8.22 :small_red_triangle_up: ( previous job: 7.67, degradation: 107.21%)
  • whonix-workstation-17_exec-root: 52.20 🟢 ( previous job: 58.26, improvement: 89.58%)
  • whonix-workstation-17_socket: 8.91 :small_red_triangle_up: ( previous job: 8.19, degradation: 108.78%)
  • whonix-workstation-17_socket-root: 8.93 :small_red_triangle_up: ( previous job: 8.13, degradation: 109.87%)
  • whonix-workstation-17_exec-data-simplex: 54.02 🟢 ( previous job: 74.99, improvement: 72.03%)
  • whonix-workstation-17_exec-data-duplex: 73.49 :small_red_triangle_up: ( previous job: 72.71, degradation: 101.07%)
  • whonix-workstation-17_exec-data-duplex-root: 98.19 🟢 ( previous job: 99.82, improvement: 98.37%)
  • whonix-workstation-17_socket-data-duplex: 165.82 🟢 ( previous job: 169.50, improvement: 97.83%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants