tests: only close watch fd for LocalVM #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 70.24% 70.21% -0.03%
==========================================
Files 59 59
Lines 12739 12747 +8
==========================================
+ Hits 8948 8950 +2
- Misses 3791 3797 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025041403-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests16 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 10 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:16 performance degradations
Remaining performance tests:56 tests
|
This was referenced Apr 10, 2025
Merged
marmarek
requested changes
Apr 12, 2025
qubes/tests/__init__.py
Outdated
Comment on lines
883
to
886
| if ( | ||
| getattr(vm, "_qdb_connection_watch", None) | ||
| and vm._qdb_connection_watch is not None | ||
| ): |
Member
There was a problem hiding this comment.
Suggested change
| if ( | |
| getattr(vm, "_qdb_connection_watch", None) | |
| and vm._qdb_connection_watch is not None | |
| ): | |
| if getattr(vm, "_qdb_connection_watch", None) is not None: |
This was referenced Apr 13, 2025
fepitre
force-pushed
the
fix-tests-localvm
branch
from
0918bc0 to
33c0521
Compare
marmarek
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #669.