Move device-related exceptions to the exc module #672
Conversation
Admin API, especially the client side depends on having all exceptions in one place. The exc.py need to be synchronized to core-admin-client repo. Exceptions from outside this module are translated to a generic QubesException, which is not perfect. Specifically, exceptions in wrong place caused DeviceAlreadyAssigned and DeviceAlreadyAttached being translate to QubesException, which confused salt module.
Similar to the previous commit, keep all exceptions in one place.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
- Coverage 70.24% 70.19% -0.05%
==========================================
Files 59 59
Lines 12739 12747 +8
==========================================
Hits 8948 8948
- Misses 3791 3799 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025041215-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests37 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 9 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:16 performance degradations
Remaining performance tests:56 tests
|
2 participants
Admin API, especially the client side depends on having all exceptions
in one place. The exc.py need to be synchronized to core-admin-client
repo. Exceptions from outside this module are translated to a generic
QubesException, which is not perfect.
Specifically, exceptions in wrong place caused DeviceAlreadyAssigned and
DeviceAlreadyAttached being translate to QubesException, which confused
salt module.