Skip to content

updater: split qubes-download-dom0-updates.sh#576

Open
piotrbartman wants to merge 2 commits intoQubesOS:mainfrom
piotrbartman:updater/dom0
Open

updater: split qubes-download-dom0-updates.sh#576
piotrbartman wants to merge 2 commits intoQubesOS:mainfrom
piotrbartman:updater/dom0

Conversation

@piotrbartman
Copy link
Member

Splitting the file allows for code reuse and improves readability

@marmarek
Copy link
Member

This has conflicts now...

@marmarek
Copy link
Member

RPM package fails to build :(

@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.18%. Comparing base (1f542b7) to head (08476dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   71.18%   71.18%           
=======================================
  Files           3        3           
  Lines         479      479           
=======================================
  Hits          341      341           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented Jun 23, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025121602-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update

  • system_tests_network_updates
    • TC_00_Dom0Upgrade_whonix-gateway-18: test_000_update (error)
      subprocess.CalledProcessError: Command 'timeout=120; while ! tor-ci...

Failed tests

1 failures
  • system_tests_network_updates
    • TC_00_Dom0Upgrade_whonix-gateway-18: test_000_update (error)
      subprocess.CalledProcessError: Command 'timeout=120; while ! tor-ci...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/158999#dependencies
Nothing fixed

Unstable tests

Details

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

Splitting the file allows for code reuse and improves readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants