updater: use qubes-vm-update to update dom0 non-interactively#264
Open
piotrbartman wants to merge 11 commits intoQubesOS:mainfrom
Open
updater: use qubes-vm-update to update dom0 non-interactively#264piotrbartman wants to merge 11 commits intoQubesOS:mainfrom
piotrbartman wants to merge 11 commits intoQubesOS:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 92.99% 93.04% +0.04%
==========================================
Files 64 64
Lines 13034 12894 -140
==========================================
- Hits 12121 11997 -124
+ Misses 913 897 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marmarta
suggested changes
Jun 10, 2025
| for vm in qapp.domains: | ||
| if vm.klass == "AdminVM": | ||
| try: | ||
| if settings.hide_skipped and bool( |
Member
There was a problem hiding this comment.
I might be confused here, but I think the check for skip-update is needed?
Member
Author
There was a problem hiding this comment.
It's in lines 123–126 (dom0 is now treated like the other VMs).
Member
|
This has conflicts now... |
piotrbartman
force-pushed
the
updater/dom0
branch
from
634aaed to
6c2c9dd
Compare
Member
|
opening updater from the widget failed with: I'm not sure if it's related to this PR, I'll restart the test.. |
This was referenced Jul 8, 2025
update tests
piotrbartman
force-pushed
the
updater/dom0
branch
from
6c2c9dd to
49a10e0
Compare
This was referenced Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GUI updater shows dom0 update progress
for test requires: QubesOS/qubes-core-admin-client/pull/404
requires: QubesOS/qubes-core-admin-linux/pull/191