Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move Freestyle OPA templates to ui5-test-writer #2928

Merged
merged 49 commits into from
Feb 24, 2025
Merged

move Freestyle OPA templates to ui5-test-writer #2928

merged 49 commits into from
Feb 24, 2025

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Feb 17, 2025 •
edited
Loading

#2932

  • Added EJS freestyle test templates to ui5-writer-tests ad logic.
  • Added addUnits flag to freestyle Fiori App to enable tests.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 6b65c4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@sap-ux/fiori-freestyle-writer Minor
@sap-ux/fiori-generator-shared Minor
@sap-ux/ui5-test-writer Minor
@sap-ux/odata-service-inquirer Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/inquirer-common Patch
@sap-ux/ui5-library-reference-sub-generator Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/create Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/adp-tooling Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/preview-middleware Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjose90
Copy link
Member Author

kjose90 commented Feb 21, 2025

@IainSAP @devinea Previously I had combined templatepackages/ui5-test-writer/templates/common/testsuite.qunit.js to be used by both FE and FF ( commit line 1 and 11 ) However, this caused whitespace discrepancies, making it challenging to align with FE snapshots. To resolve this, I reverted the change and opted to handle testsuite.qunit.js separately under freestyle templates.

devinea
devinea reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.
I think it would be easier to maintain going forward if to split templates based on UI5 template version e.g. 1.71.0 and 1.120.0

devinea
devinea reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests to the writer tests packages/fiori-freestyle-writer/test/basic.test.ts ?
1.71.xand >1.120 cases.

IainSAP
IainSAP previously approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kjose90

  • All comments addressed
  • Updates are clear
  • Tests to cover
  • Pending comments from @devinea to be addressed (will need re-aproval)

@kjose90
Copy link
Member Author

kjose90 commented Feb 21, 2025

Can you add tests to the writer tests packages/fiori-freestyle-writer/test/basic.test.ts ? 1.71.xand >1.120 cases.

done

devinea
devinea approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests freestyle tests look good.
Thanks for updates.
Changeset 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

IainSAP
IainSAP approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving thanks.

@kjose90 kjose90 merged commit fffc3a7 into main Feb 24, 2025
16 checks passed
@kjose90 kjose90 deleted the freestyle-test-templates branch February 24, 2025 09:11
@kjose90
Copy link
Member Author

kjose90 commented Feb 24, 2025

Thanks for reviews 👍

This was referenced Feb 26, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinea devinea devinea approved these changes

@IainSAP IainSAP IainSAP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjose90 @devinea @IainSAP