Support passing a URL for individual check results #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
the
[Type] Enhancement
swissspidy
requested review from
barrykooij,
chriscct7,
davidperezgar and
frantorres
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for this PR @swissspidy I think it now looks great. I recommend a strong in the first line.
What do you think @frantorres @barrykooij ? |
davidperezgar
approved these changes
Jul 31, 2024
ernilambar
approved these changes
Aug 1, 2024
barrykooij
approved these changes
Aug 1, 2024
|
Looks great, this will be super helpful! |
mukeshpanchal27
approved these changes
Aug 1, 2024
davidperezgar
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #461, see #316. Fixes #355 by not escaping the result message in the admin.
Specifically implements this suggestion. Here's a screenshot:
It's up to the team to add longer error messages and add docs URLs where applicable (either in this PR or new PRs).