Use ServiceID to match VPC Endpoint Service in ReadMany operation #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
ack-prow
bot
added
the
do-not-merge/work-in-progress
knottnt
commented
Jul 8, 2025
|
/test all |
|
/retest |
knottnt
force-pushed
the
endpoint-service-matching
branch
from
640a2ad to
2251ee3
Compare
|
/retest |
knottnt
force-pushed
the
endpoint-service-matching
branch
from
2251ee3 to
22a4b21
Compare
|
/retest |
1 similar comment
|
/retest |
knottnt
force-pushed
the
endpoint-service-matching
branch
from
22a4b21 to
73e0514
Compare
|
/retest |
ack-prow
bot
removed
the
do-not-merge/work-in-progress
knottnt
force-pushed
the
endpoint-service-matching
branch
from
73e0514 to
4ea0400
Compare
knottnt
commented
Jul 10, 2025
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
michaelhtm
reviewed
Jul 22, 2025
- Use ServiceID as matching field for list operation - Update synced check to use Available instead of available
knottnt
force-pushed
the
endpoint-service-matching
branch
3 times, most recently
from
2d7939b to
709bf41
Compare
|
/retest |
knottnt
force-pushed
the
endpoint-service-matching
branch
from
709bf41 to
22fe3cc
Compare
michaelhtm
reviewed
Jul 24, 2025
templates/hooks/vpc_endpoint_service_configuration/sdk_read_many_pre_build_request.go.tpl
Outdated
Show resolved
Hide resolved
knottnt
force-pushed
the
endpoint-service-matching
branch
from
22fe3cc to
7287224
Compare
- Add custom required fields check to fail ReadMany operation if ServiceID not set. - Add hook to include ServiceID as filter for ReadMany API request - undo code-gen change to fail matching criteria check for nil Status fields
knottnt
force-pushed
the
endpoint-service-matching
branch
from
7287224 to
6578ea3
Compare
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
michaelhtm
reviewed
Jul 25, 2025
|
Nice |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 2547
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.