-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Procedural atmospheric scattering #16314
Conversation
and more things as well
mostly
and more things as well
mostly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really comment on the math, but the results look good and the implementation itself is fine.
I added a few minor comments but none of them are blockers.
bevy_example_runner results: https://pixel-eagle.com/project/B25A040A-A980-4602-B90C-D480AB84076D?filter=PR-16314 Nothing seems super out of place |
Unassigning myself as this has enough reviews already. |
Agreed, merging :) Thanks! |
should fix NaN issue, scene seems unaffected
Implement procedural atmospheric scattering from [Sebastien Hillaire's 2020 paper](https://sebh.github.io/publications/egsr2020.pdf). This approach should scale well even down to mobile hardware, and is physically accurate. ## Co-author: @mate-h He helped massively with getting this over the finish line, ensuring everything was physically correct, correcting several places where I had misunderstood or misapplied the paper, and improving the performance in several places as well. Thanks! ## Credits @aevyrie: helped find numerous bugs and improve the example to best show off this feature :) Built off of @mtsr's original branch, which handled the transmittance lut (arguably the most important part) ## Showcase:   ## For followup - Integrate with pcwalton's volumetrics code - refactor/reorganize for better integration with other effects - have atmosphere transmittance affect directional lights - add support for generating skybox/environment map --------- Co-authored-by: Emerson Coskey <[email protected]> Co-authored-by: atlv <[email protected]> Co-authored-by: JMS55 <[email protected]> Co-authored-by: Emerson Coskey <[email protected]> Co-authored-by: Máté Homolya <[email protected]>
Implement procedural atmospheric scattering from Sebastien Hillaire's 2020 paper. This approach should scale well even down to mobile hardware, and is physically accurate.
Co-author: @mate-h
He helped massively with getting this over the finish line, ensuring everything was physically correct, correcting several places where I had misunderstood or misapplied the paper, and improving the performance in several places as well. Thanks!
Credits
@aevyrie: helped find numerous bugs and improve the example to best show off this feature :)
Built off of @mtsr's original branch, which handled the transmittance lut (arguably the most important part)
Showcase:
For followup