Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure bevy_utils is included with std feature #18201

Merged
merged 2 commits into from
Mar 8, 2025
Merged

Ensure bevy_utils is included with std feature #18201

merged 2 commits into from
Mar 8, 2025

Conversation

bushrat011899
Copy link
Contributor

Objective

Solution

  • Ensure bevy_utils is included with bevy_transform/std

Testing

  • cargo build --no-default-features --features std

Notes

Compilation failure was caused by bevy_transform's new parallel propagation system requiring bevy_utils/std when bevy_transform/std was active, but it was left optional. Additionally, bevy_transform/async_executor wasn't being enabled by bevy/async_executor.

@bushrat011899 bushrat011899 added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Transform Translations, rotations and scales P-Compile-Failure A failure to compile Bevy apps X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 8, 2025
@bushrat011899
Copy link
Contributor Author

check-advisories failure is unrelated to this PR.

@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 8, 2025
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Mar 8, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 8, 2025
Merged via the queue into bevyengine:main with commit c14733d Mar 8, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aevyrie aevyrie aevyrie approved these changes

@mnmaita mnmaita mnmaita approved these changes

Assignees
No one assigned
Labels
A-Transform Translations, rotations and scales C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.16
4 participants
@bushrat011899 @aevyrie @mnmaita @alice-i-cecile