Sync up the Derive of DragEntry to match the other events #18220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Peepo-Juice
changed the title
jnhyatt
reviewed
Mar 10, 2025
| @@ -278,7 +278,7 @@ pub struct DragDrop { | |||
| } | |||
|
|
|||
| /// Dragging state. | |||
| #[derive(Debug, Clone)] | |||
| #[derive(Clone, PartialEq, Debug, Reflect)] | |||
| pub struct DragEntry { | |||
There was a problem hiding this comment.
Hmmm I don't believe DragEntry is a pointer event. Doesn't mean we don't want these impls for it but I am curious what you're doing that wanted them
There was a problem hiding this comment.
I'm working with bevy_mod_scripting so I need things to be Reflect so I can send it over to the Lua side :)
There was a problem hiding this comment.
Ah ok so you're not actually using the PartialEq, just the reflect
alice-i-cecile
added
D-Trivial
jnhyatt
approved these changes
Mar 11, 2025
Olle-Lukowski
approved these changes
Mar 11, 2025
Olle-Lukowski
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add
#[derive(Clone, PartialEq, Debug, Reflect)]to DragEntry so it matches the other picking events.Solution
Copy/paste (RIP Larry Tesler)
Testing
Just ran cargo check. I don't believe this should break anything because I did not remove any derives it had before.