Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scene_viewer example to use Children::spawn #18253

Closed
wants to merge 2 commits into from
Closed

Update scene_viewer example to use Children::spawn #18253

wants to merge 2 commits into from
+11 −15

Conversation

krunchington
Copy link
Contributor

@krunchington krunchington commented Mar 11, 2025 •
edited
Loading

Objective

Contributes to #18238
Updates the scene_viewer example to use the Children::spawn method.

Solution

Updates examples to use the Improved Spawning API merged in #17521

Testing

  • Did you test these changes? If so, how?
    • Opened the examples before and after and verified the same behavior was observed. I did this on Ubuntu 24.04.2 LTS using --features wayland.
  • Are there any parts that need more testing?
    • Other OS's and features can't hurt, but this is such a small change it shouldn't be a problem.
  • How can other people (reviewers) test your changes? Is there anything specific they need to know?
    • Run the examples yourself with and without these changes.
  • If relevant, what platforms did you test these changes on, and are there any important ones you can't test?
    • see above

Showcase

n/a

Migration Guide

n/a

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples labels Mar 11, 2025
@alice-i-cecile alice-i-cecile requested a review from cart March 11, 2025 05:46
@alice-i-cecile alice-i-cecile added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed D-Trivial Nice and easy! A great choice to get started with Bevy labels Mar 11, 2025
Olle-Lukowski
Olle-Lukowski approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@Olle-Lukowski Olle-Lukowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Olle-Lukowski Olle-Lukowski added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 11, 2025
@krunchington
Copy link
Contributor Author

If #18259 gets accepted, I would recommend closing this PR and merging that instead (as it will cause merge conflicts but that PR will supersede this one)

@cart
Copy link
Member

cart commented Mar 11, 2025

Closing in favor of #18259

@cart cart closed this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Olle-Lukowski Olle-Lukowski Olle-Lukowski approved these changes

@cart cart Awaiting requested review from cart

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krunchington @cart @alice-i-cecile @Olle-Lukowski