Skip to content

taplo sort #21545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

taplo sort #21545

wants to merge 1 commit into from

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Oct 14, 2025 •
edited
Loading

Objective

  • dep order is inconsistent

Solution

  • taplo config sort deps option

Testing

  • ci

kristoff3r
kristoff3r reviewed Oct 14, 2025
View reviewed changes
@alice-i-cecile
Copy link
Member

This would be enforced in CI right?

I'm fine with this, but really don't care much.

jasmine-nominal
jasmine-nominal reviewed Oct 15, 2025
View reviewed changes
crates/bevy_pbr/Cargo.toml
fixedbitset = "0.5"
thiserror = { version = "2", default-features = false }
derive_more = { version = "2", default-features = false, features = ["from"] }
# meshlet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meshlet section should probably have a newline so it dosen't get mixed up.

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change X-Controversial There is active debate or serious implications around merging this PR A-Cross-Cutting Impacts the entire engine S-Needs-Design This issue requires design work to think about how it would best be accomplished labels Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kristoff3r kristoff3r kristoff3r left review comments

@jasmine-nominal jasmine-nominal jasmine-nominal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Cross-Cutting Impacts the entire engine C-Code-Quality A section of code that is hard to understand or change S-Needs-Design This issue requires design work to think about how it would best be accomplished X-Controversial There is active debate or serious implications around merging this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atlv24 @alice-i-cecile @kristoff3r @jasmine-nominal