Skip to content

Allow DiagnosticsBuffer to be applied even if DiagnosticsStore is missing. #21550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

Allow DiagnosticsBuffer to be applied even if DiagnosticsStore is missing. #21550

merged 1 commit into from
Oct 23, 2025

Conversation

@andriyDev
Copy link
Contributor

Objective

Solution

  • Avoid panicking in DiagnosticsBuffer::apply if the world is missing the DiagnosticsStore.
  • Clear the buffer if DiagnosticsStore is missing to prevent growing the buffer.

Testing

  • None.

@andriyDev andriyDev added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Diagnostics Logging, crash handling, error reporting and performance analysis S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 14, 2025
@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 23, 2025
@mockersf mockersf added this pull request to the merge queue Oct 23, 2025
Merged via the queue into bevyengine:main with commit 8253eab Oct 23, 2025
38 checks passed
@andriyDev andriyDev deleted the fix-diag-buffer branch October 23, 2025 23:04
@chescock chescock mentioned this pull request Oct 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

+1 more reviewer

@chescock chescock chescock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andriyDev @chescock @mockersf