Skip to content

Opt-in a DirectionalLight for atmospheric scattering #21839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Opt-in a DirectionalLight for atmospheric scattering #21839

wants to merge 10 commits into from
+244 −36

Conversation

@hukasu
Copy link
Contributor

@hukasu hukasu commented Nov 14, 2025

Objective

Closes #21748

Solution

Add a AtmosphericScattering component to allow to opt-in on a DirectionalLight influencing on atmosphere

Alternative

Invert so that the component is for opting-out

Testing

atmosphere example and new atmosphere_multiple_directional_lights example

Showcase

image image image

@hukasu hukasu requested review from alice-i-cecile, ecoskey and mate-h and removed request for mate-h November 14, 2025 12:22
@hukasu hukasu added A-Rendering Drawing game state to the screen M-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

@hukasu hukasu changed the title Issue21748 Opt-in a DirectionalLight for atmospheric scattering Nov 14, 2025
@hukasu hukasu requested a review from mate-h November 14, 2025 13:05
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes labels Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecoskey ecoskey Awaiting requested review from ecoskey

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

@mate-h mate-h Awaiting requested review from mate-h

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes M-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Rendering
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Atmospheric scattering on some DirectionalLight's but not all?

2 participants

@hukasu @alice-i-cecile