Skip to content

Fix entity display not working with padding. #21850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

Fix entity display not working with padding. #21850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions crates/bevy_ecs/src/entity/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,9 +671,13 @@ impl fmt::Debug for Entity {
impl fmt::Display for Entity {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
if self == &Self::PLACEHOLDER {
write!(f, "PLACEHOLDER")
f.pad("PLACEHOLDER")
} else {
write!(f, "{}v{}", self.index(), self.generation())
f.pad(&alloc::fmt::format(format_args!(
"{}v{}",
self.index(),
self.generation()
)))
}
}
}
Expand Down Expand Up @@ -1514,6 +1518,12 @@ mod tests {
let string = format!("{entity}");
assert_eq!(string, "42v0");

let padded_left = format!("{entity:<5}");
assert_eq!(padded_left, "42v0 ");

let padded_right = format!("{entity:>6}");
assert_eq!(padded_right, " 42v0");

let entity = Entity::PLACEHOLDER;
let string = format!("{entity}");
assert_eq!(string, "PLACEHOLDER");
Expand Down
Loading