Skip to content

Add Observer::with_components #21857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Observer::with_components #21857

wants to merge 1 commit into from
+7 −0

Conversation

@Shatur
Copy link
Contributor

@Shatur Shatur commented Nov 16, 2025

Objective

Solution

  • Add Observer::with_components, for consistency with Observer::with_entities for entities.

Testing

  • I didn't test it, but it's a very simple helper function, similar to already existing Observer::with_component (singular).

@Shatur Shatur added this to the 0.17.3 milestone Nov 16, 2025
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 16, 2025
@mockersf mockersf modified the milestones: 0.17.3, 0.17.4 Nov 17, 2025
@hymm hymm added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@hymm hymm hymm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

None yet

Milestone

0.17.4

Development

Successfully merging this pull request may close these issues.

Add Observer::add_component

4 participants

@Shatur @hymm @alice-i-cecile @mockersf