Fix font ID leak in TextPipeline
#22386
Merged
+42
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, creating a new font with a new font ID to cosmic text's FontDb from the font asset each text update. This commit removes the responsibility of loading fonts to cosmic text's database and associating them with an asset id from `TextPipeline`. Instead the font family name is added to the `Font` asset after loading. Then in `TextPipeline::update_buffer` it just gets the family name from the asset and there's no possibility of a leak.
ickshonpe
added
C-Bug
ickshonpe
changed the title
update_buffer now leaks font IDs…TextPipeline
alice-i-cecile
approved these changes
Jan 5, 2026
alice-i-cecile
added
the
M-Migration-Guide
ickshonpe
added
the
P-Critical
tychedelia
approved these changes
Jan 7, 2026
Member
tychedelia
left a comment
tychedelia
left a comment
There was a problem hiding this comment.
Oof, yeah okay. Nice fix! Makes sense.
tychedelia
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
#22156 introduced a leak 😓 . Every time a text section with a font handle font source is updated in
TextPipeLine::update_buffer, a new font with a new font ID is added to cosmic text's FontDb.Fixes #22419
Solution
Remove font loading and asset-ID association from TextPipeline. Instead, add the font family name to the
Fontasset after loading. Thenupdate_buffercan just use the family name from the asset.Testing
Add this system to the
textexample (or any bevy app with updating text):You should observe the count increasing with every text update on main. The count should be stable with this PR.