Skip to content

Conversation

@kfc35
Copy link
Contributor

@kfc35 kfc35 commented Jan 6, 2026

Objective

Solution

  • Use warn_once for the log message (and add bevy_log as a dependency for bevy_pbr)

Testing

I added main.rs in the reproduction repo https://github.com/logankaser/bevy-uniforms-pipeline-repro/blob/main/src/main.rs as an example file in the main bevy repo and ran it with bevy run --example repro --features=bevy_camera,bevy_core_pipeline,bevy_log,bevy_pbr,bevy_render,bevy_window,bevy_winit,webgpu web --open.

I opened up the app in Chrome and verified in the console log that the warning only fires once

screenshots of console logs In google chrome beforehand, you see the spam in the console: Screenshot 2026-01-05 at 10 04 57 PM

After the change, it just warns once:
Screenshot 2026-01-06 at 12 06 14 AM

@kfc35 kfc35 marked this pull request as ready for review January 6, 2026 03:16
@kfc35 kfc35 changed the title Fix: "The build mesh uniforms pipeline wasn't ready” warning only fires once Fix: "The build mesh uniforms pipeline wasn't ready” warning fires only once Jan 6, 2026
@kfc35 kfc35 force-pushed the 22358_excessive_warning branch from 2f00bbd to d2b570e Compare January 6, 2026 03:17
@kfc35 kfc35 force-pushed the 22358_excessive_warning branch from d2b570e to 2aa5625 Compare January 6, 2026 05:03
@kfc35 kfc35 changed the title Fix: "The build mesh uniforms pipeline wasn't ready” warning fires only once Fix: "The build mesh uniforms pipeline wasn't ready” warning now fires only once Jan 6, 2026
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a dedicated warn_once! macro for exactly this :)

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen O-Web Specific to web (WASM) builds S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jan 6, 2026
@alice-i-cecile alice-i-cecile added this to the 0.18 milestone Jan 6, 2026
@kfc35
Copy link
Contributor Author

kfc35 commented Jan 6, 2026

We have a dedicated warn_once! macro for exactly this :)

Hah I had that initially but then changed it to once!(warn()) because I had to add bevy_log as a dependency and did not now how that would be received!

I'll change it back to warn_once!

@kfc35 kfc35 requested a review from alice-i-cecile January 6, 2026 16:07
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jan 6, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 6, 2026
Merged via the queue into bevyengine:main with commit feb0dc6 Jan 6, 2026
44 checks passed
@github-project-automation github-project-automation bot moved this to Done in Rendering Jan 6, 2026
cart pushed a commit that referenced this pull request Jan 8, 2026
…s only once (#22398)

- Fixes #22358

- Use `warn_once` for the log message (and add `bevy_log` as a
dependency for `bevy_pbr`)

I added `main.rs` in the reproduction repo
https://github.com/logankaser/bevy-uniforms-pipeline-repro/blob/main/src/main.rs
as an example file in the main `bevy` repo and ran it with `bevy run
--example repro
--features=bevy_camera,bevy_core_pipeline,bevy_log,bevy_pbr,bevy_render,bevy_window,bevy_winit,webgpu
web --open`.

I opened up the app in Chrome and verified in the console log that the
warning only fires once

<details>
<summary>screenshots of console logs</summary>
In google chrome beforehand, you see the spam in the console:
<img width="705" height="285" alt="Screenshot 2026-01-05 at 10 04 57 PM"
src="https://github.com/user-attachments/assets/7fe4cb1c-2df3-4d3b-a80d-4dfdaf2efb68"
/>

After the change, it just warns once:
<img width="728" height="62" alt="Screenshot 2026-01-06 at 12 06 14 AM"
src="https://github.com/user-attachments/assets/c269f10e-1a7f-4daf-a8c8-dc812895eb68"
/>

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

0.18.0-rc.2 WASM "The build mesh uniforms pipeline wasn't ready" log spam

3 participants