Repository navigation
fix(graphics): keep discarded import probes from pinning windows - #6097
Conversation
|
Tested on Linux x86-64 (Release build, lavapipe / llvmpipe LLVM 20.1.2), with a7730cb merged into main ab9a476:
Lavapipe refuses the host import ( AI-assisted: yes (Claude Code) |
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Checked on Linux (merged onto current main): build and the libSceAgcDriver ctest scope are green except |
What
A stale-registry probe stamps an ordinary prefix host import as used before rejecting it. That false hold can block a valid import of the whole registered allocation. Separate lookup from accepted-use stamping; preserve actual descriptor holds and stamp accepted joined/exact-run reuse.
Related: #5870 promotes genuinely held windows, a different condition. Both patches apply in either order against the same base and produce identical combined blobs. Their combined runtime behavior has not been tested.
Tested
Windows x64, GCC 15.2, Ninja Release:
4808d9cplus the new regression: target build passed;agc_driver_graphicsfailed at the intended discarded-prefix assertion.038c83b9: rebuiltagc_driver_graphics_tests, reran its CPU/mock test, and passed the upstream convention checker.The regression checks unheld prefix replacement, protection of an actual held descriptor, and accepted reuse/stamping, including allocation extent, registered owner/import identity, descriptor contents, and unchanged guest bytes. Physical GPU host-import lifetime and Linux CI remain untested. No game-menu or performance claim.
Checklist
mainat038c83b9; open-PR overlap checked, no duplicate discarded-probe fix found