AnnotationBear: Return precise string/comment info #1332

aptrishu · 2017-01-20T00:54:57Z

Earlier the return used to be either a tuple of
source ranges of strings/comments now it is a
tuple of namedtuples with fields
"start_delimiter_range end_delimiter_range content_range full_range"
of singleline strings/multiline strings/singlieline comments/multiline comments
Also, It modifies KeywordBear, QuotesBear,
IndentationBear and their tests.

gitmate-bot · 2017-01-20T00:55:14Z

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
I have followed the guidelines for the commit shortlog.
I have followed the guidelines for the commit body.
I have included the issue URL.
I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

gitmate-bot · 2017-01-20T00:56:02Z

Comment on e017fa2.

Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.

GitCommitBear, severity NORMAL, section commit.

gitmate-bot · 2017-01-20T00:56:02Z

Comment on e017fa2.

Shortlog of the HEAD commit contains 54 character(s). This is 4 character(s) longer than the limit (54 > 50).

GitCommitBear, severity NORMAL, section commit.

aptrishu · 2017-01-23T16:41:53Z

CC @jayvdb.
Please take a look at the pickle error in coala-ci log in circleCI.
namedtuple is creating a problem with pickle IMO.. should I use dict instead. Though namedtuple is easy to use..

jayvdb · 2017-01-25T21:35:25Z

bears/general/AnnotationBear.py

-                    self.get_singleline_strings)
-                if end_position and _range:
-                    strings_range.append(_range)
+                end_position, start_delim, end_delim =\


please add a space after the equals, here and below

jayvdb · 2017-01-25T21:53:56Z

bears/general/AnnotationBear.py

+        multiline_comment_range = []
+        fields = ('start_delimiter_range end_delimiter_range'
+                  ' content_range full_range')
+        singleline_string = namedtuple('singleline_string', fields)


http://stackoverflow.com/questions/16377215/how-to-pickle-a-namedtuple-instance-correctly

Done with dict..

aptrishu · 2017-01-26T15:22:35Z

@jayvdb It's still failing, I have put namedtuples outside the class.
If we use pickle from dill (https://github.com/uqfoundation/dill) it would be easily done without any such issues.

aptrishu · 2017-01-30T00:02:41Z

All errors are resolved..

sils · 2017-02-03T17:10:03Z

@aptrishu is this still wip? With that in the title you aren't getting any reviews and this is so important :( we need to merge it within hours

aptrishu · 2017-02-03T18:48:47Z

Ohh I forgot to remove WIP from the tittle, Though I had labelled it pending review. so, it must be showing in review queue.

gitmate-bot · 2017-07-14T16:10:29Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-22T01:57:20Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-08-24T08:52:20Z

tests/general/AnnotationBearTest.py

+            AbsolutePosition(text, 0),
+            AbsolutePosition(text, len(text[0]) - 2))
+
+        compare_content = []


This file contains unused source code.

PyUnusedCodeBear, severity NORMAL, section flakes.

The issue can be fixed by applying the following patch:

--- a/tests/general/AnnotationBearTest.py +++ b/tests/general/AnnotationBearTest.py @@ -62,7 +62,6 @@ AbsolutePosition(text, 0), AbsolutePosition(text, len(text[0]) - 2)) - compare_content = [] compare_start = SourceRange.from_absolute_position( 'F',

gitmate-bot · 2017-08-24T08:52:20Z

bears/general/AnnotationBear.py

@@ -1,3 +1,5 @@
+import sys


This file contains unused source code.

PyUnusedCodeBear, severity NORMAL, section flakes.

The issue can be fixed by applying the following patch:

--- a/bears/general/AnnotationBear.py +++ b/bears/general/AnnotationBear.py @@ -1,4 +1,3 @@ -import sys from coalib.bearlib.languages.LanguageDefinition import LanguageDefinition from coalib.bears.LocalBear import LocalBear

gitmate-bot · 2017-10-03T10:19:30Z

bears/general/AnnotationBear.py

@@ -1,3 +1,5 @@
+import sys


This file contains unused source code.

Origin: PyUnusedCodeBear, Section: flakes.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp255z_p7_/bears/general/AnnotationBear.py +++ b/tmp/tmp255z_p7_/bears/general/AnnotationBear.py @@ -1,4 +1,3 @@ -import sys from coalib.bearlib.languages.LanguageDefinition import LanguageDefinition from coalib.bears.LocalBear import LocalBear

gitmate-bot · 2017-10-03T10:19:31Z

tests/general/AnnotationBearTest.py

+            AbsolutePosition(text, 0),
+            AbsolutePosition(text, len(text[0]) - 2))
+
+        compare_content = []


This file contains unused source code.

Origin: PyUnusedCodeBear, Section: flakes.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp255z_p7_/tests/general/AnnotationBearTest.py +++ b/tmp/tmp255z_p7_/tests/general/AnnotationBearTest.py @@ -62,7 +62,6 @@ AbsolutePosition(text, 0), AbsolutePosition(text, len(text[0]) - 2)) - compare_content = [] compare_start = SourceRange.from_absolute_position( 'F',

Earlier the return used to be either a tuple of source ranges of strings/comments now it is a tuple of dicts with keys 'start_delimiter_range', 'end_delimiter_range' 'content_range', 'full_range' of singleline strings/multiline strings/singleline comments/multiline comments.

aptrishu · 2017-10-08T08:43:24Z

@Makman2 @userzimmermann review needed. :P

userzimmermann

@aptrishu I took a quick look again and... IMO this needs a complete redesign

cc @sils

jayvdb · 2017-11-03T07:00:45Z

bears/general/QuotesBear.py


        for string_range in ranges:
-            if (file[string_range.start.line-1][string_range.start.column-1] ==
+            temp_range = string_range.full_range


there is no need to use a different variable here.
Earlier, do

- ranges = annotation_dict['strings'] + ranges = [x.full_range for x in annotation_dict['strings']]

gitmate-bot added process/wip size/XL review carefully! labels Jan 20, 2017

aptrishu mentioned this pull request Jan 20, 2017

WIP AnnotationBear: return precise string/comment info #1323

Closed

aptrishu force-pushed the annot2 branch 6 times, most recently from 78ae5cc to 26ccdf8 Compare January 22, 2017 08:08

jayvdb requested changes Jan 25, 2017

View reviewed changes

aptrishu force-pushed the annot2 branch from 26ccdf8 to 3cf3328 Compare January 26, 2017 12:53

aptrishu force-pushed the annot2 branch 3 times, most recently from 775f009 to 2b2deff Compare January 29, 2017 23:28

aptrishu added process/pending review and removed process/wip labels Jan 29, 2017

sils added this to the 0.10 milestone Feb 3, 2017

aptrishu changed the title ~~WIP AnnotationBear: Return precise string/comment info~~ AnnotationBear: Return precise string/comment info Feb 3, 2017

aptrishu force-pushed the annot2 branch from 2b2deff to 77cb0d3 Compare February 3, 2017 21:25

Mixih added the needs backport label Feb 6, 2017

abh3po added the area/genericbears label Feb 9, 2017

aptrishu force-pushed the annot2 branch from 1a4e349 to 4207d9b Compare August 24, 2017 08:51

gitmate-bot added process/pending review and removed process/wip labels Aug 24, 2017

gitmate-bot reviewed Aug 24, 2017

View reviewed changes

gitmate-bot added the status/STALE label Sep 1, 2017

aptrishu force-pushed the annot2 branch from 4207d9b to 4c3649f Compare October 3, 2017 10:19

gitmate-bot added size/L and removed size/XXL labels Oct 3, 2017

gitmate-bot reviewed Oct 3, 2017

View reviewed changes

gitmate-bot removed the status/STALE label Oct 3, 2017

aptrishu force-pushed the annot2 branch 4 times, most recently from fa5e192 to e6468ee Compare October 6, 2017 07:23

aptrishu force-pushed the annot2 branch from e6468ee to a3348df Compare October 6, 2017 08:14

gitmate-bot added the status/STALE label Oct 16, 2017

aptrishu mentioned this pull request Oct 19, 2017

PyUnrunDoctestsBear: Detect doctests that are not actually run #1283

Open

userzimmermann requested changes Oct 22, 2017

View reviewed changes

This was referenced Oct 22, 2017

Redesign coalib.bearlib.languages on top of pygments coala/coala#4775

Open

Pygmented AnnotationBear #2092

Open

jayvdb requested changes Nov 3, 2017

View reviewed changes

co-robo added process/wip and removed process/pending review labels Nov 13, 2017

aptrishu mentioned this pull request Dec 18, 2017

QuotesBear fails to process multi line strings in the same line correctly #1024

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AnnotationBear: Return precise string/comment info #1332

AnnotationBear: Return precise string/comment info #1332

aptrishu commented Jan 20, 2017

gitmate-bot commented Jan 20, 2017

gitmate-bot commented Jan 20, 2017

gitmate-bot commented Jan 20, 2017

aptrishu commented Jan 23, 2017 •

edited

Loading

jayvdb Jan 25, 2017

jayvdb Jan 25, 2017

aptrishu Jan 29, 2017

aptrishu commented Jan 26, 2017

aptrishu commented Jan 30, 2017

sils commented Feb 3, 2017

aptrishu commented Feb 3, 2017 •

edited

Loading

gitmate-bot commented Jul 14, 2017

gitmate-bot commented Jul 22, 2017

gitmate-bot Aug 24, 2017

gitmate-bot Aug 24, 2017

gitmate-bot Oct 3, 2017

gitmate-bot Oct 3, 2017

aptrishu commented Oct 8, 2017

userzimmermann left a comment

jayvdb Nov 3, 2017

AnnotationBear: Return precise string/comment info #1332

Are you sure you want to change the base?

AnnotationBear: Return precise string/comment info #1332

Conversation

aptrishu commented Jan 20, 2017

gitmate-bot commented Jan 20, 2017

gitmate-bot commented Jan 20, 2017

gitmate-bot commented Jan 20, 2017

aptrishu commented Jan 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aptrishu commented Jan 26, 2017

aptrishu commented Jan 30, 2017

sils commented Feb 3, 2017

aptrishu commented Feb 3, 2017 • edited Loading

gitmate-bot commented Jul 14, 2017

gitmate-bot commented Jul 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aptrishu commented Oct 8, 2017

userzimmermann left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aptrishu commented Jan 23, 2017 •

edited

Loading

aptrishu commented Feb 3, 2017 •

edited

Loading