Skip to content

Conversation

@JananiPSrinivasan
Copy link
Collaborator

Google tests are implemented along with the updated Github actions workflow.

@jbrzensk
Copy link
Collaborator

@cpaolini From our meeting, you are going to call them "testn", not "testn_gtest"

@cpaolini
Copy link
Collaborator

Correct. We will remove the _gtest substring in the filename.

@JananiPSrinivasan
Copy link
Collaborator Author

@jbrzensk @cpaolini
I have renamed the files to "testsn", verified the build after renaming and pushed the code to the branch again. Kindly review.

@pritkc pritkc added the Enhancement New feature or request label Feb 20, 2025
Copy link
Collaborator

@jbrzensk jbrzensk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good.
The build fails the checks/actions.

test1.cpp:2:10: fatal error: gtest/gtest.h: No such file or directory
    2 | #include <gtest/gtest.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:[31](https://github.com/csrc-sdsu/mole/actions/runs/13440527158/job/37553556545?pr=71#step:5:32): test1] Error 1
make[1]: Leaving directory '/home/runner/work/mole/mole/tests/cpp'
make: *** [Makefile:17: tests/cpp] Error 2
Error: Process completed with exit code 2.

@JananiPSrinivasan
Copy link
Collaborator Author

Check Failure Reason

  • C/C++ CI workflow fails in this PR because the test cases which ran with the old makefile and has been removed
  • C/C++ CI workflow does not include the library for gtest framework
  • Checks initially passed because we had both the test files required to pass the C/C++ CI workflow and the Build and Test workflow, but now it has been removed and hence the error
  • Build and Test workflow has handled the gtest framework issue.
    After this PR has been merged, the C/C++ CI workflow is to be taken down as they do not include gtest framework and it supports the old test case files

@jbrzensk @cpaolini

@cpaolini cpaolini merged commit 16d23bb into master Feb 20, 2025
10 of 12 checks passed
@JananiPSrinivasan JananiPSrinivasan deleted the gtest branch February 21, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants