-
Notifications
You must be signed in to change notification settings - Fork 141
refactor: Add TypeScript support #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
==========================================
+ Coverage 76.91% 79.25% +2.33%
==========================================
Files 55 59 +4
Lines 2270 2694 +424
Branches 255 333 +78
==========================================
+ Hits 1746 2135 +389
- Misses 494 523 +29
- Partials 30 36 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@06kellyjac - can we get a review and confirm whether this would constitute a patch or minor bump? Any opine welcome @jescalada too 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These suggestions would ensure npx @finos/git-proxy
continues to work.
Although the package in npm wouldn't work properly if someone is doing require("@finos/git-proxy")
(or import
) from plain JS. We probably want to build out valid JS with type defs for the published package
Squashing the commits down would be appreciated 🙂 |
@fabiovincenzi - can you take a look at the comments and we can get this merged? |
a3f23bb
to
e7ec595
Compare
e7ec595
to
e316a95
Compare
Hey @06kellyjac, @JamieSlome, I've addressed all the comments and cleaned up the commit history by squashing the relevant commits. Thanks! 😊 |
@06kellyjac - are we ready to merge? What is the recommend version bump here, minor or patch? |
No, I don't think this is importable from javascript as-is. We'll need to build out js and type definitions for the published package. |
Hey @06kellyjac, Could you clarify what you mean by "not importable from JavaScript as-is"? I thought git-proxy was being executed directly through the Also, do you want us to generate the JS and type definitions and include them in the publishing workflow for npm? Let me know how you'd like to proceed. Thanks! 😊 |
Hi @06kellyjac, @JamieSlome, I went ahead and implemented the changes to make the package importable from JavaScript/TypeScript:
Could you take a look and let me know if this covers the requirements you asked for? Thanks! 😊 |
Thanks, I'll have a play with it. |
Thanks Jack. Keen to get this merged soon! |
@jescalada - can we resolve conflicts? @06kellyjac - if no other issues, I'd like to merge this 👍 |
@@ -2,6 +2,8 @@ | |||
"name": "@finos/git-proxy", | |||
"version": "1.11.0", | |||
"description": "Deploy custom push protections and policies on top of Git.", | |||
"main": "dist/index.js", | |||
"types": "dist/index.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moving to dist
would break existing usecases
not everything is exported or accessible via main/index atm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to go with this for a cut of v2 some time in the future
This comment was marked as outdated.
This comment was marked as outdated.
Thanks for flagging this! @coopernetes This PR has been open for quite a while and had fallen behind If the commit history still feels noisy, I can rebase or cherry-pick these changes onto a fresh branch. |
Overview
This PR introduces TypeScript to git-proxy and refactors relevant code to support it.
Changelog
Thanks to @jescalada for the work on fixing CI issues on G-Research#31, which helped guide the necessary changes in this PR.
Related issue: #927