fix: metrics previously did not wait for confirmation #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 7, 2025
This was referenced May 7, 2025
dylanlott
approved these changes
May 8, 2025
prestwich
force-pushed
the
prestwich/normalize-tracing
branch
from
b6e4c46 to
fb9f608
Compare
prestwich
force-pushed
the
prestwich/fix-metrics
branch
2 times, most recently
from
aa49dc4 to
f6843d0
Compare
prestwich
force-pushed
the
prestwich/normalize-tracing
branch
from
fb9f608 to
71ea1d3
Compare
prestwich
force-pushed
the
prestwich/fix-metrics
branch
from
f6843d0 to
2f7b513
Compare
prestwich
force-pushed
the
prestwich/normalize-tracing
branch
from
71ea1d3 to
1d48594
Compare
prestwich
force-pushed
the
prestwich/fix-metrics
branch
from
2f7b513 to
cc9f11c
Compare
prestwich
force-pushed
the
prestwich/normalize-tracing
branch
from
1d48594 to
6050bed
Compare
prestwich
force-pushed
the
prestwich/fix-metrics
branch
from
cc9f11c to
710eacb
Compare
prestwich
force-pushed
the
prestwich/normalize-tracing
branch
from
6050bed to
79a0493
Compare
prestwich
force-pushed
the
prestwich/fix-metrics
branch
from
710eacb to
f447e78
Compare
prestwich
force-pushed
the
prestwich/normalize-tracing
branch
from
79a0493 to
509b9f4
Compare
Merged
prestwich
force-pushed
the
prestwich/fix-metrics
branch
from
f447e78 to
bf796ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: updates the metrics task to use a pending tx watcher instead of
get_receipt. this will allow it to wait for the transaction to confirm