chore: delte constants" #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2025
This was referenced May 12, 2025
Merged
prestwich
force-pushed
the
prestwich/quincey-breakout
branch
2 times, most recently
from
33aa899 to
84264ed
Compare
prestwich
force-pushed
the
prestwich/delete-constants
branch
from
04ec775 to
4ca1540
Compare
prestwich
force-pushed
the
prestwich/quincey-breakout
branch
from
84264ed to
9e7902f
Compare
prestwich
force-pushed
the
prestwich/delete-constants
branch
from
4ca1540 to
79d15aa
Compare
dylanlott
reviewed
May 12, 2025
| @@ -347,7 +346,7 @@ impl Simulator { | |||
| Some(basefee) => basefee, | |||
| None => { | |||
| warn!("get basefee failed - RPC error likely occurred"); | |||
| BASEFEE_DEFAULT | |||
| todo!() | |||
There was a problem hiding this comment.
Is this intended in this commit?
There was a problem hiding this comment.
yes and explicitly flagged in the pr description. i would rather have a crash than faulty behavior
dylanlott
approved these changes
May 12, 2025
prestwich
force-pushed
the
prestwich/delete-constants
branch
from
79d15aa to
aabcbe0
Compare
lint: fmt fix: typo
prestwich
force-pushed
the
prestwich/quincey-breakout
branch
from
80e5727 to
bfc3500
Compare
prestwich
force-pushed
the
prestwich/delete-constants
branch
from
d5e6102 to
27eaeed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete the constants, add a
TODOfor the basefee