Skip to content

fix: use new sdk #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

fix: use new sdk #81

merged 2 commits into from
May 8, 2025

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented May 8, 2025

use the new constants crate

* refactor: update config to use derive

* fix: not optional

* refactor: normalize tracing imports
@prestwich prestwich marked this pull request as ready for review May 8, 2025 19:05
@prestwich prestwich requested review from Evalir and dylanlott as code owners May 8, 2025 19:05
Copy link
Member

@rswanson rswanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also remove the env vars and replace them with values from the pecorino chain constants?

@prestwich
Copy link
Member Author

no. that comes later

@prestwich prestwich merged commit 4f8f6ae into main May 8, 2025
5 checks passed
@prestwich prestwich deleted the prestwich/new-sdk branch May 8, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants