Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0018] SPIRV resource representation #98

Merged
merged 10 commits into from
Mar 3, 2025
Merged

[0018] SPIRV resource representation #98

merged 10 commits into from
Mar 3, 2025

Conversation

s-perron
Copy link
Collaborator

@s-perron s-perron commented Nov 8, 2024

Adds a proposal for how HLSL resources will be represented in llvm-ir
when targeting SPIR-V.

@s-perron s-perron force-pushed the spirv_resources branch 5 times, most recently from a5e3294 to 06203dc Compare November 14, 2024 16:03
@s-perron s-perron mentioned this pull request Jan 27, 2025
Open
4 tasks
@s-perron s-perron mentioned this pull request Feb 7, 2025
Merged
@s-perron s-perron requested a review from Keenuts February 28, 2025 18:42
@s-perron s-perron marked this pull request as ready for review February 28, 2025 18:46
cassiebeckley
cassiebeckley reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@cassiebeckley cassiebeckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally good to me, with a couple comments about the name of VulkanBuffer and the use of spirv.DecoratedType.

Keenuts
Keenuts approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@Keenuts Keenuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor question.
I wonder what would be the stance on language-level intrinsincs for things like buffer which are not yet fully lowered, and highly represents an HLSL concept

llvm-beanz
llvm-beanz reviewed Mar 3, 2025
View reviewed changes
proposals/XXXX-spirv-resource-representation.md Outdated
structs have appropriate padding at the end to ensure its size is a multiple
of its alignment.
3. Matrix stride?
4. Row major vs Col major?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to spend some time soon figuring out a design and plan for matrix types. There is a lot of complication there to figure out which will impact both DXIL and SPIRV.

@s-perron s-perron changed the title SPIRV resource representation [0018] SPIRV resource representation Mar 3, 2025
@s-perron s-perron merged commit 181a5a6 into llvm:main Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keenuts Keenuts Keenuts approved these changes

@llvm-beanz llvm-beanz llvm-beanz approved these changes

@cassiebeckley cassiebeckley cassiebeckley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
HLSL Support
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s-perron @cassiebeckley @Keenuts @llvm-beanz