Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SendPrimitiveAsync throws InvalidOperationException for enums #291

Merged
merged 11 commits into from
Jul 12, 2024
Merged

SendPrimitiveAsync throws InvalidOperationException for enums #291

merged 11 commits into from
Jul 12, 2024

Conversation

MartinM85
Copy link
Contributor

Closes #274

@MartinM85 MartinM85 requested a review from a team as a code owner July 10, 2024 07:38
andrueastman
andrueastman reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging

tests/http/httpClient/RequestAdapterTests.cs Outdated Show resolved Hide resolved
baywet
baywet reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting the PR here! We'll need to merge #292 before we can merge this one in. But besides that it looks good to me.

src/abstractions/IRequestAdapter.cs Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@MartinM85 MartinM85 force-pushed the fix/247-enums-sendprimitiveasync branch from 1eabf75 to 982faa6 Compare July 11, 2024 06:44
baywet
baywet reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the trimming testing project!

tests/trimming/Microsoft.Kiota.Trimming.Validation/Microsoft.Kiota.Trimming.Validation.csproj Show resolved Hide resolved
baywet
baywet reviewed Jul 12, 2024
View reviewed changes
src/Directory.Build.props Outdated Show resolved Hide resolved
@MartinM85 MartinM85 requested a review from baywet July 12, 2024 13:11
baywet
baywet reviewed Jul 12, 2024
View reviewed changes
Directory.Build.props Outdated Show resolved Hide resolved
baywet
baywet approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the continuous work on this one. @andrueastman for final review and merge.

andrueastman
andrueastman approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

Really appreciate the work here @MartinM85

src/Directory.Build.props Show resolved Hide resolved
@andrueastman andrueastman merged commit 880bff6 into microsoft:main Jul 12, 2024
7 checks passed
@andrueastman andrueastman mentioned this pull request Jul 12, 2024
Closed
@andrueastman andrueastman linked an issue Jul 12, 2024 that may be closed by this pull request
Unknown type for deserialization when trying to get enum collection in C# #278
Closed
@andrueastman andrueastman mentioned this pull request Jul 12, 2024
Merged
@baywet baywet mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
conflicting
Projects
Kiota
Archived in project
Milestone
No milestone
3 participants
@MartinM85 @andrueastman @baywet