Update/fix restitution param desc in physics addons #32341
Conversation
examples/jsm/physics/JoltPhysics.js
Outdated
| * @param {Mesh} mesh The mesh to add. | ||
| * @param {number} [mass=0] The mass in kg of the mesh. | ||
| * @param {number} [restitution=0] The restitution/friction of the mesh. | ||
| * @param {number} [restitution=0] The restitution of the mesh. |
There was a problem hiding this comment.
In very simple words one can distinct both concepts like so:
- Restitution models how "bouncy" objects are when they collide with each other.
- Friction models how object slide against each other.
Is that about right?
There was a problem hiding this comment.
Yeah, but friction isn't exposed at all
There was a problem hiding this comment.
Correct. Would you mind updating the description of restitution to the following:
@param {number} [restitution=0] The restitution of the mesh. Represents how "bouncy" objects are when they collide with each other.
In this way, we have a bit of description about what restitution actually is.
There was a problem hiding this comment.
How about The restitution of the mesh usually from 0 to 1. Restitution is the proportion of energy conserved when colliding with another object
There was a problem hiding this comment.
And in the future The frictional coefficient of the mesh, above or equal to 0 where 0 is no friction. When two objects slide against each other there is a frictional force proportional to the normal force between them and this value
There was a problem hiding this comment.
Then maybe like so?
The amount of energy conserved when colliding with another object. Simply speaking, it defines how "bouncy" objects are when they collide with each other.
I would like to add one sentence that defines it as simple as possible for developers who do not know much about physics yet.
There was a problem hiding this comment.
What I've written is accurate and concise, for wadafak is this (probably more for people who don't speak English rather than poor physics) I think it should be
The restitution of the mesh usually from 0 to 1. This is how "bouncy" an object is
The friction of the mesh, above or equal to 0, where 0 is no friction. Friction is a force applied when objects slide against each other
There was a problem hiding this comment.
TBH, I prefer the version in #32341 (comment) which is a it longer but more clear.
There was a problem hiding this comment.
I don't think "on colliding with eachother" adds anything, but I am impartial to the extra words. We should keep the range 0 to 1 though
SollyBunny
changed the title
friction in param desc of physics AddMesh
2 participants
Uh oh!
There was an error while loading. Please reload this page.