-
Notifications
You must be signed in to change notification settings - Fork 129
chore: set minimum node version to 20 #3310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set minimum node version to 20 #3310
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
PR Review: Set Minimum Node Version to 20SummaryThis PR adds a minimum Node.js version requirement of 20 to the root package.json. While this is a good practice for ensuring consistency, there are several inconsistencies across the codebase that should be addressed. Issues FoundCritical: Version Inconsistencies Across Package.json FilesThe codebase has conflicting Node.js version requirements:
Warning: Documentation InconsistenciesExamples documentation has varying Node.js requirements:
Recommendations
Code QualityThe change itself is syntactically correct and follows proper package.json format. Suggested Next StepsBefore merging, please:
|
More templates
@rivetkit/actor
@rivetkit/cloudflare-workers
@rivetkit/core
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
@rivetkit/engine-runner
@rivetkit/engine-runner-protocol
commit: |
d825c16 to
e17af20
Compare
b14522c to
f51b221
Compare
e17af20 to
141efff
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/limits#rate-limits |
Code ReviewSummaryThis PR sets the minimum Node.js version to 20 in the root package.json. While this is a reasonable change, there are significant inconsistencies across the codebase that should be addressed. Issues Found1. Inconsistent Node Version RequirementsThe codebase has multiple conflicting Node version specifications:
The rivetkit package requires Node 22+, which is HIGHER than the root requirement of 20. 2. CI/CD ConfigurationGitHub Actions workflows use Node 20, which is consistent with this PR. 3. Docker Configurationengine/sdks/typescript/test-runner/Dockerfile uses node:22-slim 4. Documentation InconsistenciesMultiple example READMEs specify different Node requirements (18+, 20+, 22+) Recommendations
Code QualityThe change itself is clean and follows correct package.json format. Action Items
|
Merge activity
|
f51b221 to
d5c5825
Compare
141efff to
33ba42a
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/limits#rate-limits |
Code ReviewSummaryThis PR sets the minimum Node.js version to 20 in the root workspace Findings1. Inconsistent Node Version Requirements Across Workspace
|

No description provided.