Open
Conversation
Contributor
Author
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a high-fidelity vision simulation mode, configurable via a Gradle property. The changes include passing the 'highFidelityVision' flag to the simulation JVM and adjusting camera resolution and minimum target area constants accordingly. A review comment suggests refining the 'kMinTargetAreaPixels' value for high-fidelity mode to 133.0 to ensure it scales proportionally with the resolution increase, maintaining consistency across simulation modes.
koolpoolo
changed the title
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
jamesdooley4
requested changes
Apr 15, 2026
Member
jamesdooley4
left a comment
jamesdooley4
left a comment
There was a problem hiding this comment.
Also need to update VisionSim to change the estStdDev calculation based on the low fidelity / high fidelity switch. See how they were changed when the low-fidelity change was made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just run ./gradlew simulateJava -PhighFidelityVision=true
to turn on higher res