Skip to content

Conversation

@saikishor
Copy link
Member

@saikishor saikishor commented Oct 14, 2025

We had an issue recently that one of the upper-level torque reference provider controllers failed to activate, and this has caused the other controllers in the chain to have an invalid zero reference to tracking and which closely destroyed our robot. For this reason, I'm proposing this behaviour, while using BEST_EFFORT strictness, it should be similar to the current approach and however, with the STRICT strictness, if one of them fails to activate, then just deactivate all of the group.

I'll need to handle the same situation when it happens in the update cycle, that I'll do it in a different PR

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 92.07921% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.46%. Comparing base (da81eb1) to head (3af6fdf).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ontroller_manager/test/test_controller_manager.cpp 92.64% 5 Missing ⚠️
controller_manager/src/controller_manager.cpp 91.30% 1 Missing and 1 partial ⚠️
...ontroller_manager/test/test_release_interfaces.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2669      +/-   ##
==========================================
+ Coverage   89.40%   89.46%   +0.05%     
==========================================
  Files         152      152              
  Lines       17223    17320      +97     
  Branches     1432     1434       +2     
==========================================
+ Hits        15399    15496      +97     
- Misses       1244     1246       +2     
+ Partials      580      578       -2     
Flag Coverage Δ
unittests 89.46% <92.07%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/controller_manager/controller_manager.hpp 97.36% <ø> (ø)
...e_interface/include/hardware_interface/helpers.hpp 96.87% <100.00%> (+0.32%) ⬆️
...ontroller_manager/test/test_release_interfaces.cpp 90.27% <85.71%> (-0.24%) ⬇️
controller_manager/src/controller_manager.cpp 76.80% <91.30%> (+0.39%) ⬆️
...ontroller_manager/test/test_controller_manager.cpp 95.34% <92.64%> (-0.20%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikishor saikishor added backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. and removed backport-humble Triggers PR backport to ROS 2 humble. labels Oct 17, 2025
@bmagyar bmagyar merged commit a2e56e4 into ros-controls:master Oct 23, 2025
15 of 17 checks passed
@bmagyar bmagyar deleted the deactive_whole_chain/upon_failed_activation branch October 23, 2025 16:26
mergify bot pushed a commit that referenced this pull request Oct 23, 2025
mergify bot pushed a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants