Skip to content

ci: separate release notification errors for safe retries - #708

Merged
zimeg merged 1 commit into
mainfrom
notify-own-job
Nov 16, 2026
Merged

zimeg merged 1 commit into
mainfrom
notify-own-job

Conversation

@zimeg

@zimeg zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member

Summary

This pull request moves the Slack release announcement out of the publish job into a separate notify job, so a webhook hiccup only turns notify red while publish stays green.

  • publish now exposes releaseExists and version as job outputs:, and notify reads them with needs: publish.
  • notify runs when needs.publish.outputs.releaseExists == 'false' and only on slackapi/slack-github-action, with contents: read.
  • errors: true on the step makes a rejected post (e.g. a revoked webhook) fail the job. With the default errors: false it only logs and stays green.
  • If an announcement fails, gh run rerun <id> --failed retries just notify with the outputs from the passing publish job, without republishing. We're not adding continue-on-error, since that would hide a missed announcement. Motivated by this suggestion on the python release-notify PRs.
  • The payload values are unchanged, and the job matches the notify job in java-slack-sdk and slack-cli.

Testing

A dry run would need a real publish, so I checked the expressions instead:

  • releaseExists ← steps.check.outputs.exists, written by "Check if release exists" before the release is created, so false means this run published.
  • version ← steps.version.outputs.version, written by "Gather version". The action URL is still built from it by hand.
  • A small script parsed the workflow and confirmed each needs.publish.outputs.* in notify resolves to a job output, a step id in publish, and an output that step actually sets.
  • notify's if: has no status function, so the implicit success() skips it when publish fails or is skipped, like the old step did.
  • Diffed the job against java-slack-sdk's notify: only the if:/needs: gating and where the payload values come from differ.
  • zizmor .github/workflows/release.yml: no findings. Pedantic findings match main.
  • After merge, the next release run should show publish then notify, with the post in the release announcements channel.

Requirements

Move the Slack release announcement out of the publish job into a separate notify job that reads the published flag and payload values from job outputs, and set errors: true so a rejected post fails the job. A webhook hiccup now only turns notify red, which can be retried with gh run rerun --failed without republishing.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 13, 2026 23:22
@zimeg zimeg added this to the 4.1 milestone Nov 13, 2026
@zimeg zimeg added the github_actions Pull requests that update GitHub Actions code label Nov 13, 2026
@zimeg zimeg self-assigned this Nov 13, 2026
@changeset-bot

changeset-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a7097bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.86%. Comparing base (60a2c0a) to head (a7097bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           8        8           
  Lines         732      732           
=======================================
  Hits          731      731           
  Misses          1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! Giving notify its own job means a webhook hiccup is one quick rerun, not a republish.

Comment thread .github/workflows/release.yml Resolved
@zimeg

zimeg commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

🌟 Thanks for the kind review @mwbrooks! One webhook for every release now, and a hiccup is just a quick rerun 🔁

@zimeg
zimeg merged commit ec0f442 into main Nov 16, 2026
13 checks passed
@zimeg
zimeg deleted the notify-own-job branch November 16, 2026 22:07

This branch was successfully deployed

1 active deployment
staging — a7097bdb Deployed Nov 13, 2026 by zimeg via Run CLI tests (macos-latest) #371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants