Skip to content

Conversation

ChristofferCOASD
Copy link

@ChristofferCOASD ChristofferCOASD commented Oct 4, 2025

Allow an event to release the sleep. This is useful if a Snake file also has small miscellaneous jobs but still is configured to use a remote executor.

This would fix

snakemake/snakemake-executor-plugin-slurm#252

Summary by CodeRabbit

  • Bug Fixes
    • Shutdown of remote executions is now much more responsive, avoiding long waits during stop/abort.
    • Cancelling or exiting during remote runs completes faster, improving overall UX.
  • Refactor
    • Switched waiting logic to an event-driven approach to enable prompt wake-ups on shutdown while preserving existing polling behavior.

Copy link
Contributor

coderabbitai bot commented Oct 4, 2025

📝 Walkthrough

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly conveys that the change introduces an event mechanism to interrupt the sleep, matching the key update in the pull request without extraneous detail.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f37ecc and 86f8325.

📒 Files selected for processing (1)
  • snakemake_interface_executor_plugins/executors/remote.py (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py

⚙️ CodeRabbit configuration file

**/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.

Files:

  • snakemake_interface_executor_plugins/executors/remote.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: title-format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChristofferCOASD ChristofferCOASD changed the title Allow event to release sleep perf: Allow event to release sleep Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants