Skip to content

perf: Allow event to release sleep #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: Allow event to release sleep #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion snakemake_interface_executor_plugins/executors/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,13 @@ def __init__(

self.active_jobs = list()
self.lock = threading.Lock()
self.shutdown_event = threading.Event()
self.wait = True
self.wait_thread = threading.Thread(target=self._wait_thread)
self.wait_thread.daemon = True
self.wait_thread.start()


max_status_checks_frac = Fraction(
self.max_status_checks_per_second
).limit_denominator()
Expand Down Expand Up @@ -201,6 +203,7 @@ def _wait_thread(self):
def shutdown(self):
with self.lock:
self.wait = False
self.shutdown_event.set()
self.wait_thread.join()
if not self.workflow.remote_execution_settings.immediate_submit:
# Only delete tmpdir (containing jobscripts) if not using
Expand Down Expand Up @@ -272,7 +275,11 @@ async def sleep(self):
if self.next_seconds_between_status_checks is None
else self.next_seconds_between_status_checks
)
await asyncio.sleep(duration)
loop = asyncio.get_running_loop()
await loop.run_in_executor(
None, lambda: self.shutdown_event.wait(timeout=duration)
)


@property
def next_seconds_between_status_checks(self):
Expand Down
Loading