Repository navigation
Conversation
theduke
force-pushed
the
split/napi-09-checkpoint-fairness
branch
from
October 22, 2026 07:55
0210b81 to
367f477
Compare
This was referenced Oct 22, 2026
theduke
force-pushed
the
split/napi-09-checkpoint-fairness
branch
from
October 22, 2026 08:00
367f477 to
c26ecdd
Compare
theduke
force-pushed
the
split/napi-09-checkpoint-fairness
branch
from
October 22, 2026 08:20
c26ecdd to
daff275
Compare
theduke
marked this pull request as ready for review
October 22, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A foreground V8 task can post its successor while it runs. Draining until the queue becomes empty allowed this chain to monopolize one checkpoint, delaying the guest event loop and streamed responses during major GC.
Process one ready foreground task per checkpoint and report admitted/pending work so control returns to the guest between successive tasks. Preserve microtask/finalizer ordering and teardown draining. A deterministic standalone V8 process posts a self-repeating task and verifies that one checkpoint returns with work pending.
This is a scheduling change with no public API additions. The standalone regression owns V8 initialization/disposal to avoid contaminating the shared native test environments.
Stack and provenance
#93 → #94 → #95 → #96 → #97 → #98 → #99 → #100 → #101
Part 9 of the audited split of #84, reconstructed on current main
eac0a13fa65a4d6103864d875ed76ab7efb1816e. Review againstsplit/napi-08-metered-wasm; predecessor branches are required. Original PR #84 remains unchanged. The stack preserves newer main host-JS behavior and deliberately excludes the unused frozen 0.0.1 ABI adapter.Validation
Build/run
napi_v8_foreground_checkpoint_test(foreground_checkpoint_fairness) and the native promise runner (test_35_promise).The CMake test is named
napi_v8.foreground_checkpoint_fairness, so the existingmake test-napiworkflow selects it alongside the promise runner. Final branch CI is pending. No additional local execution was performed after the user requested tests stop.Latest-main rebase
Rebased the dependency stack onto
eac0a13fa65a4d6103864d875ed76ab7efb1816eafter main merged PR #92. This preserves unsigned guest IDs, pointers and lengths, bounded result/argv writes, host-JS buffer failure cleanup and the high-pointer/high-ID regressions. Conflicts received independent native and host-JS source review. All historical local results above predate this rebase; no local tests or builds were run for it, as requested. Updated-head validation belongs to CI and may be pending. This PR keeps its prerequisite branch as its base to preserve the focused diff.