Repository navigation
Conversation
theduke
force-pushed
the
split/napi-06-wasm-policy
branch
from
October 22, 2026 07:55
1ad58ca to
f472255
Compare
This was referenced Oct 22, 2026
theduke
force-pushed
the
split/napi-06-wasm-policy
branch
from
October 22, 2026 08:00
f472255 to
7ed41f1
Compare
theduke
force-pushed
the
split/napi-06-wasm-policy
branch
from
October 22, 2026 08:20
7ed41f1 to
89c0e97
Compare
theduke
marked this pull request as ready for review
October 22, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 WebAssembly memories and code bypass the guest ArrayBuffer allocator. Guest environments therefore need a restrictive default, while the trusted host needs an explicit way to select a policy before accounting-backed enablement.
Add Rust
WasmPolicyconfiguration and carry it into each provider environment and VM context through a private environment-creation entry. Keep the native public creation signature and the guest's wasm32 options layout unchanged: a guest cannot set or inspect host policy. Unknown values reject creation and release the transferred guest heap exactly once.The default remains restricted.
EnabledUnmeteredis an explicit trusted-use option; its WebAssembly memory/code/compiler work is not covered by tenant accounting. VM code-generation restrictions and fresh realms continue to fail closed where required. The next two PRs add the accounting required by the metered option.Stack and provenance
#93 → #94 → #95 → #96 → #97 → #98 → #99 → #100 → #101
Part 6 of the audited split of #84, reconstructed on current main
eac0a13fa65a4d6103864d875ed76ab7efb1816e. Review againstsplit/napi-05-heap-safety; predecessor branches are required. Original PR #84 remains unchanged. The stack preserves newer main host-JS behavior and deliberately excludes the unused frozen 0.0.1 ABI adapter.Validation
Restricted/unmetered root and VM context tests,
codeGeneration.wasm, fresh realms, successive contexts, unknown policy and exact-once guest-heap release.Integrated unit and host-control coverage completed before local execution stopped at the user’s request. New CI runs the native policy tests and Rust unit tests; final branch results are pending. The public standalone SDK and the intended Edge SDK have distinct shared-memory detachment capabilities, documented in the accounting PR.
Latest-main rebase
Rebased the dependency stack onto
eac0a13fa65a4d6103864d875ed76ab7efb1816eafter main merged PR #92. This preserves unsigned guest IDs, pointers and lengths, bounded result/argv writes, host-JS buffer failure cleanup and the high-pointer/high-ID regressions. Conflicts received independent native and host-JS source review. All historical local results above predate this rebase; no local tests or builds were run for it, as requested. Updated-head validation belongs to CI and may be pending. This PR keeps its prerequisite branch as its base to preserve the focused diff.