Repository navigation
Conversation
theduke
force-pushed
the
split/napi-07-page-accounting
branch
from
October 22, 2026 07:55
9346c66 to
c42873f
Compare
This was referenced Oct 22, 2026
theduke
force-pushed
the
split/napi-07-page-accounting
branch
from
October 22, 2026 08:00
c42873f to
00769a1
Compare
theduke
force-pushed
the
split/napi-07-page-accounting
branch
from
October 22, 2026 08:20
00769a1 to
24604b6
Compare
theduke
marked this pull request as ready for review
October 22, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resizable ArrayBuffers and growable SharedArrayBuffers reserve and commit pages through V8's platform allocator, bypassing its ordinary ArrayBuffer allocator. Growing such a buffer could consume resident memory without charging the tenant.
Wrap the platform page allocator, attribute buffer-shaped reservations to the active instance lane, charge committed prefixes before OS operations, and return charges on shrink, decommit and free. Denied soft charges return a JavaScript RangeError. A tracked allocation retains its accountant until its last owner frees it, including shared buffers outliving their original context.
Avoid locking on ordinary heap/code pages through the exclusion fast path. Reject unattributed buffer-shaped reservations once managed metering is enabled, while retaining the explicit standalone behavior.
The classifier relies on the pinned V8 archive's allocation alignment and reservation conventions; the included classifier and partial-unmap tests must be revisited when that archive changes. This PR does not itself enable nested WebAssembly.
Stack and provenance
#93 → #94 → #95 → #96 → #97 → #98 → #99 → #100 → #101
Part 7 of the audited split of #84, reconstructed on current main
eac0a13fa65a4d6103864d875ed76ab7efb1816e. Review againstsplit/napi-06-wasm-policy; predecessor branches are required. Original PR #84 remains unchanged. The stack preserves newer main host-JS behavior and deliberately excludes the unused frozen 0.0.1 ABI adapter.Validation
v8_page_accounting: resize/grow/shrink/soft denial, concurrent contexts, shared-buffer single charge, transfers, GC/teardown, attribution, classifier and exclusion-table trimming; soft-budget and accountant ownership unit tests.The final page-accounting suite was not reached before the user requested all further local tests stop. The new native Rust CI job explicitly selects this suite. Final branch execution is pending; keep draft.
Latest-main rebase
Rebased the dependency stack onto
eac0a13fa65a4d6103864d875ed76ab7efb1816eafter main merged PR #92. This preserves unsigned guest IDs, pointers and lengths, bounded result/argv writes, host-JS buffer failure cleanup and the high-pointer/high-ID regressions. Conflicts received independent native and host-JS source review. All historical local results above predate this rebase; no local tests or builds were run for it, as requested. Updated-head validation belongs to CI and may be pending. This PR keeps its prerequisite branch as its base to preserve the focused diff.