Repository navigation
fix(agc): skip devices without required BDA features - #4847
Draft
Isrrael101 wants to merge 1 commit into
Draft
Isrrael101 wants to merge 1 commit into
Isrrael101 wants to merge 1 commit into
Conversation
This was referenced Oct 15, 2026
This was referenced Oct 15, 2026
This was referenced Oct 15, 2026
Merged
This was referenced Oct 15, 2026
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This was referenced Oct 15, 2026
Closed
11 tasks done
12 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The GPU selector accepts a discrete adapter with graphics, compute and presentation queues before checking its required BDA features. WSL's Dozen adapter for an RTX 3060 is selected despite lacking
VK_KHR_8bit_storage, so device initialization fails instead of using the available compatible lavapipe device.Probe the existing byte-storage and buffer-device-address requirements before accepting each candidate. Log the rejection reason and continue selecting among compatible adapters. Explicit
ANYPS5_GPUfiltering still applies. Document the selection requirements.Tested
Ubuntu 26.04 under WSL, Intel i7-11370H, Mesa 26.2.4. Full relinker and patched system-library build completed.
agc_driver_device_selectionpassed with Dozen and lavapipe both installed; the unsupported NVIDIA and Intel Dozen adapters were skipped.agc_driver_bda_devicepassed withVK_DRIVER_FILES=/usr/share/vulkan/icd.d/lvp_icd.json(the default adapter skips this test because it lacks byte storage)._umtx_op, guest module directories and Intel conversion passed.git diff --checkpassed.Checklist
main; no other open PR implements the same functions