Repository navigation
Conversation
|
Independent Windows check of
Exact tool/test blobs were extracted from Git; the workspace checkout was unchanged. Python/synthetic files only: no title replay, native build, CMake/CTest, GPU or Linux/macOS run. Composition with #5571 or current main was not tested; the overlap still needs handling separately. AI-assisted testing and reporting: OpenAI Codex. |
79b5bcd to
a12828c
Compare
|
@MarcZX10 @ggkouujere-debug I checked #6171 rebased to
Pinned heads, candidate patches, replay commands and results. Which merge order would you prefer? I can handle the rebase and the identity-side resolution here after either of yours lands. The PR currently declares no semantic dependency; I will update that once we agree on an order. There is also fresh author-run Windows and Linux validation of the rebased tool/test files. The actual PPSA28319 audit still changes exit 1 to 0 and four absent imports to zero. This fixes a false preflight failure; the game already runs. If anyone has the same declared-name mismatch on another title, an audit report would help establish the broader impact. PPSA28319 remains our only confirmed affected title. AI-assisted testing and reporting: OpenAI Codex. |
|
Thank you for the thorough analysis! I've verified the combination locally: merged both PRs, applied I agree with your proposed merge order: #7454 first, then #6171 with your rebase. Please proceed with the identity-side resolution on your end. Appreciate the collaboration! |
|
@johnohhh1 @ggkouujere-debug I'll queue our Windows host-library capitalization fix after both of these PRs, preserving the order recorded above: #7454 -> #6171 -> our follow-up. The follow-up will declare Our branch changes only Windows host dependency lookup. Its seven regression tests cover capitalization, transitive gaps, ELF and converted PE module providers, mixed ELF/PE graphs, ambiguous variants/report preservation, and cycles. ELF name lookup stays case sensitive. Validation on Windows/Python 3.12.14:
I'll open the standalone follow-up with these dependencies and take its rebase after both land. The combined resolution is compatibility evidence, not extra implementation in that follow-up. No game runtime, full native build, Linux/macOS, or performance claim. AI-assisted implementation, testing and communication: OpenAI Codex. |
a12828c to
74c5e70
Compare
|
Thanks @ggkouujere-debug — recorded the agreed order #7454 → #6171 in Rebased this PR onto main Fresh author-run CI: Windows/Python 3.12 and 3.14 each passes 120 tests with two POSIX-only skips; Linux passes 121 with one Windows-only skip. Six CLI cases pass on each runner. The baseline control still gives 83 failed subcases and zero errors. No new native build or title run. The prepared combination with #7454 AI-assisted implementation, testing and reporting: OpenAI Codex. |
74c5e70 to
9859614
Compare
Resolve module dependencies through ELF SONAMEs and declared SCE module identities, preserving exact-name precedence and rejecting ambiguity. Keep each module import counted once across aliases and repeated inputs. Middle Ages Ping Pong (PPSA28319) reaches a rendered match on current main, but its Il2CppUserAssemblies.prx declares Il2cppUserAssemblies. The audit falsely reported four missing imports and a missing module. Add section-based and sectionless regression coverage and document the matching rules.
9859614 to
35bf15c
Compare
What
Correct a false failing import audit for Middle Ages Ping Pong, PPSA28319 01.000.000. Its
Il2CppUserAssemblies.prxdeclares the SCE identityIl2cppUserAssemblies. The relinker resolves that identity, but the audit reports four absent imports and a missing module.Read ELF SONAMEs and SCE module identities using the relinker's exact-name precedence and suffix rules. Preserve ambiguity checks, import counts and physical filename requirements for host dependencies. This corrects preflight diagnostics; the title already runs.
Merge order: #7454, then #6171, agreed with #7454's author. The prepared identity-side normalization will be applied with the rebase after #7454 lands; its implementation is not bundled here.
Tested
Head
35bf15c51, rebased cleanly onto synced main8727ddb29. The tool, tests and documentation are byte-for-byte identical to the earlier October 20 head98596149e; fresh Linux checks and the saved title audit pass again. The contribution combines declared identities with main's newModuleNamesfilename-suffix and Windows case matching. It preserves unscoped guest-import lookup, NID disambiguation normalization, PE support and the Windows host-importer set. Host lookup still receives physical module filenames rather than guest identity aliases.2626e5ee7registries/libraries and current source classification, main's tool exits 1 with four absent imports; the PR exits 0 with none. Both retain 2,355 references, 1,052 unique imports and eight stub classifications. No missing host dependencies. This reruns the audit, not the game or native build.98596149e, whose audit tool/test blobs exactly match this head; Windows was not rerun for this rebase. Fresh local Linux validation also passes all six subprocess CLI checks. The seven regression methods produce 83 failed subcases and zero errors against main's tool. No upstream native CI is claimed.11840ad87and our74c5e7029passed 122 Linux tests with one skip, plus four cross-feature methods. The author and another contributor report compatible combinations at their recorded pins. These are historical results; the combination will be revalidated after fix(tools): resolve $ORIGIN-prefixed converted module dependencies in import_audit #7454 lands on current main.Pinned evidence, CI results and replay patch. Historical runtime evidence remains main
2626e5ee7: rendered match and exit 0 after SIGINT at 45.47 s, RTX 5070/NVIDIA 595.99.02, SDL dummy audio. No full-playability, performance, console result or second affected title is claimed. Earlier independent Windows validation applies to the original revision.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)