Multi-selection: Tab switcher #5464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
42e94eb to
0d73e35
Compare
11 tasks
0nko
changed the title
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
0b382b2 to
8492b52
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
8492b52 to
c4c3cf8
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
2 times, most recently
from
c3270a9 to
e6e2148
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
e6e2148 to
ff15dd9
Compare
This was referenced Feb 3, 2025
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
ff15dd9 to
02fb482
Compare
0nko
requested review from
mikescamell
and removed request for
malmstein and
nalcalag
mikescamell
reviewed
Feb 13, 2025
Comment on lines
39
to
36
| @ContributesMultibinding( | ||
| scope = AppScope::class, | ||
| boundType = ApiInterceptorPlugin::class, | ||
| ) | ||
| class BlockListInterceptorApiPlugin @Inject constructor( | ||
| class BlockListInterceptorApiPlugin constructor( |
There was a problem hiding this comment.
❓ Why was this removed?
There was a problem hiding this comment.
Hmm, seems like this was added with a rebase.
mikescamell
approved these changes
Feb 13, 2025
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
2 times, most recently
from
eab74f4 to
3d62cf6
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
3d62cf6 to
01126c4
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
01126c4 to
b38ddf4
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
2 times, most recently
from
cca1829 to
da3cae9
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
ae964cb to
08c2d69
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
2 times, most recently
from
ec8e0fb to
40202e1
Compare
This reverts commit c61727f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207418217763355/1209148925370449/f
Description
This PR is the feature branch for the tab switcher multi-selection project.
Steps to test this PR
Nothing to test, this will serve as a feature branch.